From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Antipov Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r109898: * alloc.c (mark_object): Revert window marking code Date: Fri, 07 Sep 2012 11:30:19 +0400 Message-ID: <5049A28B.2050506@yandex.ru> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------090601030302090400060705" X-Trace: ger.gmane.org 1347003055 8227 80.91.229.3 (7 Sep 2012 07:30:55 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 7 Sep 2012 07:30:55 +0000 (UTC) Cc: Emacs development discussions To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Sep 07 09:30:52 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1T9t1Y-0006Um-AU for ged-emacs-devel@m.gmane.org; Fri, 07 Sep 2012 09:30:44 +0200 Original-Received: from localhost ([::1]:39620 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9t1V-0007Jm-6J for ged-emacs-devel@m.gmane.org; Fri, 07 Sep 2012 03:30:41 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:56709) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9t1N-0007Jd-0r for emacs-devel@gnu.org; Fri, 07 Sep 2012 03:30:38 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T9t1G-0005N7-GY for emacs-devel@gnu.org; Fri, 07 Sep 2012 03:30:32 -0400 Original-Received: from forward8.mail.yandex.net ([77.88.61.38]:34075) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9t1F-0005Il-TU for emacs-devel@gnu.org; Fri, 07 Sep 2012 03:30:26 -0400 Original-Received: from smtp9.mail.yandex.net (smtp9.mail.yandex.net [77.88.61.35]) by forward8.mail.yandex.net (Yandex) with ESMTP id D4B10F6028C; Fri, 7 Sep 2012 11:30:19 +0400 (MSK) Original-Received: from smtp9.mail.yandex.net (localhost [127.0.0.1]) by smtp9.mail.yandex.net (Yandex) with ESMTP id AF2191520780; Fri, 7 Sep 2012 11:30:19 +0400 (MSK) Original-Received: from unknown (unknown [37.139.80.10]) by smtp9.mail.yandex.net (nwsmtp/Yandex) with ESMTP id UJ0WfSHl-UJ0KvZKx; Fri, 7 Sep 2012 11:30:19 +0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1347003019; bh=tQARJ+75n8/gbQP8Ln+3ku5c5ogYfJXu9JDFTN3jvj8=; h=Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject: References:In-Reply-To:Content-Type; b=VOn5JUYLagcsyj0ZCSzpoRO0C8q2VRhqHWBVVGdLJMszdSbQcAOLDD2iArJliAgyx 83/WR4vjmvlntsM8QvsUdfmnkR0MYyHYe+xA950+n4JS6jiKrPz1eOVnqOy5ke4SB4 vobUaJN94OkwSCyYc23qJkwWE6XqIJDg3DVZw6vE= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120824 Thunderbird/15.0 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 77.88.61.38 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:153137 Archived-At: This is a multi-part message in MIME format. --------------090601030302090400060705 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 09/06/2012 04:54 PM, Stefan Monnier wrote: >> * alloc.c (mark_object): Revert window marking code >> since it's unsafe for the Fset_window_configuration. > > Please revert the rest of the patch as well. Reverted, safe approach attached. BTW, are there any reasons to reset local variables in Fkill_buffer? Dmitry --------------090601030302090400060705 Content-Type: text/plain; charset=UTF-8; name="nullify.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="nullify.patch" PT09IG1vZGlmaWVkIGZpbGUgJ3NyYy9idWZmZXIuYycKLS0tIHNyYy9idWZmZXIuYwkyMDEy LTA5LTA2IDA5OjE1OjQ0ICswMDAwCisrKyBzcmMvYnVmZmVyLmMJMjAxMi0wOS0wNyAwNzoy Nzo0NCArMDAwMApAQCAtMTcwMCw2ICsxNzAwLDE5IEBACiAgICAgfQogfQogCisvKiBTZXQg YWxsIEIncyBMaXNwX09iamVjdCBzbG90cyB0byBuaWwgaW4KKyAgIGF0dGVtcHQgdG8gbGV0 IEdDIHRvIHN3ZWVwIHRoZW0gZWFybHkuICAqLworCitzdGF0aWMgaW5saW5lIHZvaWQKK251 bGxpZnlfYnVmZmVyIChzdHJ1Y3QgYnVmZmVyICpiKQoreworICBpbnQgb2Zmc2V0OworCisg IEZPUl9FQUNIX1BFUl9CVUZGRVJfT0JKRUNUX0FUIChvZmZzZXQpCisgICAgc2V0X3Blcl9i dWZmZXJfdmFsdWUgKGIsIG9mZnNldCwgUW5pbCk7CisgIGJzZXRfdW5kb19saXN0IChiLCBR bmlsKTsKK30KKwogREVGVU4gKCJraWxsLWJ1ZmZlciIsIEZraWxsX2J1ZmZlciwgU2tpbGxf YnVmZmVyLCAwLCAxLCAiYktpbGwgYnVmZmVyOiAiLAogICAgICAgIGRvYzogLyogS2lsbCB0 aGUgYnVmZmVyIHNwZWNpZmllZCBieSBCVUZGRVItT1ItTkFNRS4KIFRoZSBhcmd1bWVudCBt YXkgYmUgYSBidWZmZXIgb3IgdGhlIG5hbWUgb2YgYW4gZXhpc3RpbmcgYnVmZmVyLgpAQCAt MTkxMSwxNCArMTkyNCwxMSBAQAogICAgICAgLyogUGVyaGFwcyB3ZSBzaG91bGQgZXhwbGlj aXRseSBmcmVlIHRoZSBpbnRlcnZhbCB0cmVlIGhlcmUuLi4gKi8KICAgICB9CiAKLSAgLyog UmVzZXQgdGhlIGxvY2FsIHZhcmlhYmxlcywgc28gdGhhdCB0aGlzIGJ1ZmZlcidzIGxvY2Fs IHZhbHVlcwotICAgICB3b24ndCBiZSBwcm90ZWN0ZWQgZnJvbSBHQy4gIFRoZXkgd291bGQg YmUgcHJvdGVjdGVkCi0gICAgIGlmIHRoZXkgaGFwcGVuZWQgdG8gcmVtYWluIGNhY2hlZCBp biB0aGVpciBzeW1ib2xzLgotICAgICBUaGlzIGdldHMgcmlkIG9mIHRoZW0gZm9yIGNlcnRh aW4uICAqLworICAvKiBHZXQgcmlkIG9mIGxvY2FsIGJpbmRpbmdzLiAgKi8KICAgc3dhcF9v dXRfYnVmZmVyX2xvY2FsX3ZhcmlhYmxlcyAoYik7Ci0gIHJlc2V0X2J1ZmZlcl9sb2NhbF92 YXJpYWJsZXMgKGIsIDEpOwogCi0gIGJzZXRfbmFtZSAoYiwgUW5pbCk7CisgIC8qIEIgaXMg cmVhbGx5IGRlYWQgYWZ0ZXIgdGhpcy4gICovCisgIG51bGxpZnlfYnVmZmVyIChiKTsKIAog ICBCTE9DS19JTlBVVDsKICAgaWYgKGItPmJhc2VfYnVmZmVyKQpAQCAtMTk0Miw5ICsxOTUy LDcgQEAKICAgICAgIGZyZWVfcmVnaW9uX2NhY2hlIChiLT53aWR0aF9ydW5fY2FjaGUpOwog ICAgICAgYi0+d2lkdGhfcnVuX2NhY2hlID0gMDsKICAgICB9Ci0gIGJzZXRfd2lkdGhfdGFi bGUgKGIsIFFuaWwpOwogICBVTkJMT0NLX0lOUFVUOwotICBic2V0X3VuZG9fbGlzdCAoYiwg UW5pbCk7CiAKICAgLyogUnVuIGJ1ZmZlci1saXN0LXVwZGF0ZS1ob29rLiAgKi8KICAgaWYg KCFOSUxQIChWcnVuX2hvb2tzKSkKCj09PSBtb2RpZmllZCBmaWxlICdzcmMvZnJhbWUuYycK LS0tIHNyYy9mcmFtZS5jCTIwMTItMDktMDQgMTc6MzQ6NTQgKzAwMDAKKysrIHNyYy9mcmFt ZS5jCTIwMTItMDktMDcgMDc6MTM6NTQgKzAwMDAKQEAgLTExMTQsNiArMTExNCwyMCBAQAog ICByZXR1cm4gMDsKIH0KIAorLyogU2V0IGFsbCBGJ3MgTGlzcF9PYmplY3Qgc2xvdHMgdG8g bmlsIGluIGF0dGVtcHQgdG8gbGV0CisgICBHQyB0byBzd2VlcCB0aGVtIGVhcmx5LiAgU2V0 dGluZyBmLT50ZXJtaW5hbCB0byBOVUxMCisgICBtYWtlcyBGUkFNRV9MSVZFX1AgZmFsc2Ug Zm9yIHRoaXMgZnJhbWUuICAqLworCitzdGF0aWMgaW5saW5lIHZvaWQKK251bGxpZnlfZnJh bWUgKHN0cnVjdCBmcmFtZSAqZikKK3sKKyAgTGlzcF9PYmplY3QgKnB0cjsKKworICBmb3Ig KHB0ciA9ICZmLT5uYW1lOyBwdHIgPD0gJmYtPmN1cnJlbnRfdG9vbF9iYXJfc3RyaW5nOyBw dHIrKykKKyAgICAqcHRyID0gUW5pbDsKKyAgZi0+dGVybWluYWwgPSBOVUxMOworfQorCiAv KiBEZWxldGUgRlJBTUUuICBXaGVuIEZPUkNFIGVxdWFscyBRbm9lbGlzcCwgZGVsZXRlIEZS QU1FCiAgIHVuY29uZGl0aW9uYWxseS4gIHhfY29ubmVjdGlvbl9jbG9zZWQgYW5kIGRlbGV0 ZV90ZXJtaW5hbCB1c2UKICAgdGhpcy4gIEFueSBvdGhlciB2YWx1ZSBvZiBGT1JDRSBpbXBs ZW1lbnRzIHRoZSBzZW1hbnRpY3MKQEAgLTEzMjEsNyArMTMzNSw5IEBACiAgIHsKICAgICBz dHJ1Y3QgdGVybWluYWwgKnRlcm1pbmFsID0gRlJBTUVfVEVSTUlOQUwgKGYpOwogICAgIGYt Pm91dHB1dF9kYXRhLm5vdGhpbmcgPSAwOwotICAgIGYtPnRlcm1pbmFsID0gMDsgICAgICAg ICAgICAgLyogTm93IHRoZSBmcmFtZSBpcyBkZWFkLiAqLworCisgICAgLyogRiBpcyByZWFs bHkgZGVhZCBhZnRlciB0aGlzLiAgKi8KKyAgICBudWxsaWZ5X2ZyYW1lIChmKTsKIAogICAg IC8qIElmIG5lZWRlZCwgZGVsZXRlIHRoZSB0ZXJtaW5hbCB0aGF0IHRoaXMgZnJhbWUgd2Fz IG9uLgogICAgICAgIChUaGlzIG11c3QgYmUgZG9uZSBhZnRlciB0aGUgZnJhbWUgaXMga2ls bGVkLikgKi8KCg== --------------090601030302090400060705--