From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r109890: Do not mark objects from deleted buffers, windows and frames. Date: Thu, 06 Sep 2012 16:42:11 +0200 Message-ID: <5048B643.1090404@gmx.at> References: <504848D0.4020908@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1346942518 17593 80.91.229.3 (6 Sep 2012 14:41:58 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 6 Sep 2012 14:41:58 +0000 (UTC) Cc: Dmitry Antipov , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Sep 06 16:41:59 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1T9dHH-0005Vs-7W for ged-emacs-devel@m.gmane.org; Thu, 06 Sep 2012 16:41:55 +0200 Original-Received: from localhost ([::1]:56077 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9dHE-0005Ue-5d for ged-emacs-devel@m.gmane.org; Thu, 06 Sep 2012 10:41:52 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:39740) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T9dHB-0005UO-Js for emacs-devel@gnu.org; Thu, 06 Sep 2012 10:41:50 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T9dHA-0000mL-Fn for emacs-devel@gnu.org; Thu, 06 Sep 2012 10:41:49 -0400 Original-Received: from mailout-de.gmx.net ([213.165.64.23]:55949) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1T9dHA-0000m7-4f for emacs-devel@gnu.org; Thu, 06 Sep 2012 10:41:48 -0400 Original-Received: (qmail invoked by alias); 06 Sep 2012 14:41:47 -0000 Original-Received: from 62-47-57-144.adsl.highway.telekom.at (EHLO [62.47.57.144]) [62.47.57.144] by mail.gmx.net (mp033) with SMTP; 06 Sep 2012 16:41:47 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX18z64FrRogzQ096Qj//JN46G5nZqNqVzsKC2+izyr qg8Ncc/HlyyPjn In-Reply-To: X-Y-GMX-Trusted: 0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 213.165.64.23 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:153111 Archived-At: > No, there can be perfectly valid reasons to access > a deleted/killed object. Its components? > I don't see anything that needs fixing here. On the contrary. It can > be very useful to keep a reference to a frame/window, and when you need > to display data, see if it's still live, and if not create a new one, > initializing some of its parameters from the old deleted one. Do you really do that? Currently, the window must be valid for that purpose. So some of your code must be broken. > I strongly disagree. I think you have an incorrect understanding of > what a "deleted/killed" object is. It really isn't dead at all. IMHO WINDOWP is often used where WINDOW_LIVE_P should be used instead. > Obviously, we don't want to NULL/nil all fields blindly. We want to do > it parsimoniously, so that we only do it for fields which we know can > safely be set this way, and ideally only for fields which do hold on to > too much data (e.g. not for fields which only contain numbers anyway). Fully agreed. martin