Change to bool only partially done?

Change to bool only partially done?

[Jan Djärv]

Hello.

After the change to bool I get lots of warnings about defvar_bool:

warning: passing argument 3 of 'defvar_bool' from incompatible pointer type 
[enabled by default]
/home/jhd/src/emacs/quickfixes/src/lisp.h:1921:13: note: expected '_Bool *' 
but argument is of type 'int *'

in these files:

Re: Change to bool only partially done?

[Jan Djärv]

2012-09-01 18:29, Jan Djärv skrev:
> Hello.
>
> After the change to bool I get lots of warnings about defvar_bool:
>
> warning: passing argument 3 of 'defvar_bool' from incompatible pointer type
> [enabled by default]
> /home/jhd/src/emacs/quickfixes/src/lisp.h:1921:13: note: expected '_Bool *'
> but argument is of type 'int *'
>
> in these files:
>

Mail escaped- These files:

alloc.c charset.c coding.c dispnew.c emacs.c eval.c fileio.c filelock.c
fns.c frame.c image.c indent.c insdel.c keyboard.c lread.c minibuf.c
print.c process.c syntax.c term.c undo.c window.c xdisp.c xfns.c
xsettings.c xterm.c

% gcc -v
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-linux-gnu/4.6/lto-wrapper
Target: x86_64-linux-gnu
Configured with: ../src/configure -v --with-pkgversion='Ubuntu/Linaro 
4.6.3-1ubuntu5' --with-bugurl=file:///usr/share/doc/gcc-4.6/README.Bugs 
--enable-languages=c,c++,fortran,objc,obj-c++ --prefix=/usr 
--program-suffix=-4.6 --enable-shared --enable-linker-build-id 
--with-system-zlib --libexecdir=/usr/lib --without-included-gettext 
--enable-threads=posix --with-gxx-include-dir=/usr/include/c++/4.6 
--libdir=/usr/lib --enable-nls --with-sysroot=/ --enable-clocale=gnu 
--enable-libstdcxx-debug --enable-libstdcxx-time=yes 
--enable-gnu-unique-object --enable-plugin --enable-objc-gc --disable-werror 
--with-arch-32=i686 --with-tune=generic --enable-checking=release 
--build=x86_64-linux-gnu --host=x86_64-linux-gnu --target=x86_64-linux-gnu
Thread model: posix
gcc version 4.6.3 (Ubuntu/Linaro 4.6.3-1ubuntu5)

How can I get rid of these annoying warnings?

	Jan D.

Re: Change to bool only partially done?

[Paul Eggert]

On 09/01/2012 09:30 AM, Jan Djärv wrote:
> --with-pkgversion='Ubuntu/Linaro 4.6.3-1ubuntu5'

So you're running on Ubuntu 12.04?  I just now
tried a build on that platform (x86), and it worked
fine for me, with no warnings even after I configured
with --enable-gcc-warnings.  This was with trunk bzr 109843.

What arguments do you pass to "configure" and to "make"?

Re: Change to bool only partially done?

[Jan Djärv]

Hello.

1 sep 2012 kl. 20:33 skrev Paul Eggert <eggert@cs.ucla.edu>:

> On 09/01/2012 09:30 AM, Jan Djärv wrote:
>> --with-pkgversion='Ubuntu/Linaro 4.6.3-1ubuntu5'
> 
> So you're running on Ubuntu 12.04?

No, Mint, the latest version.

>  I just now
> tried a build on that platform (x86), and it worked
> fine for me, with no warnings even after I configured
> with --enable-gcc-warnings.  This was with trunk bzr 109843.
> 
> What arguments do you pass to "configure" and to "make"?

configure --with-x-toolkit=gtk3
make

That is it. 

       Jan D. 

Re: Change to bool only partially done?

[Paul Eggert]

[-- Attachment #1: Type: text/plain, Size: 454 bytes --]

On 09/01/2012 01:02 PM, Jan Djärv wrote:
> configure --with-x-toolkit=gtk3
> make

Works for me, on my Ubuntu 12.04 host, with
trunk bzr 109844 from a "make dist"; see attached log.

Do you have a stray stdbool.h in your include
path?  That might explain things.

If not, please try running from a fresh bzr clone,
as the symptoms are those of source files from
different bzr versions.  If you still see
the problem we can compare logs.


[-- Attachment #2: build-log.txt.gz --]
[-- Type: application/x-gzip, Size: 18060 bytes --]

Re: Change to bool only partially done?

[Jan Djärv]

Hello.

2012-09-02 00:16, Paul Eggert skrev:
> On 09/01/2012 01:02 PM, Jan Djärv wrote:
>> configure --with-x-toolkit=gtk3
>> make
>
> Works for me, on my Ubuntu 12.04 host, with
> trunk bzr 109844 from a "make dist"; see attached log.
>
> Do you have a stray stdbool.h in your include
> path?  That might explain things.

No. i have not.  I only have
  /usr/lib/gcc/x86_64-linux-gnu/4.6/include/stdbool.h
but that file does not define the type _Bool as it is a builtin, so it would 
not explain anything.

The problem seems to be that the makefile rule to regenerate globals.h does 
not trigger.  Hence an old globals.h was used.  And as .bzrignore includes 
gazillions of files, it is hard to see that this file is not maintained by bzr.

>
> If not, please try running from a fresh bzr clone,
> as the symptoms are those of source files from
> different bzr versions.  If you still see
> the problem we can compare logs.
>

What do you mean by different bzr versions?  Are you saying that a file pulled 
by bzr 2.5 is different from a file pulled by bzr 2.6?  That is absurd.

If you mean that the clone contains files from different Emacs branches, that 
would indicate a bug in bzr itself, or that bzr status is broken.

	Jan D.

Re: Change to bool only partially done?

[Paul Eggert]

On 09/02/2012 03:45 AM, Jan Djärv wrote:

> The problem seems to be that the makefile rule to
> regenerate globals.h does not trigger.
> Hence an old globals.h was used.

That sounds like a missing dependency in the makefile rule for
gl-stamp.  I looked for something along those lines but could
not find it.  Can you reproduce the problem?  If so, what's
the output of "make -d"?  If not, perhaps the next time the
problem happens we can try to track down this bug in the
build procedure.

I did find an unrelated problem in that rule and fixed it
in trunk bzr 109859.

> What do you mean by different bzr versions?

I merely meant that the checkout wasn't consistent.
This occasionally happens, if bzr is interrupted during
a checkout.

Re: Change to bool only partially done?

[Jan Djärv]

2 sep 2012 kl. 16:36 skrev Paul Eggert <eggert@cs.ucla.edu>:

> On 09/02/2012 03:45 AM, Jan Djärv wrote:
> 
>> The problem seems to be that the makefile rule to
>> regenerate globals.h does not trigger.
>> Hence an old globals.h was used.
> 
> That sounds like a missing dependency in the makefile rule for
> gl-stamp.  I looked for something along those lines but could
> not find it.  Can you reproduce the problem?  If so, what's
> the output of "make -d"?  If not, perhaps the next time the
> problem happens we can try to track down this bug in the
> build procedure.
> 

I can't reproduce it, I'll look out for miisig generation in the future and do a better debugging if it happens.

> I did find an unrelated problem in that rule and fixed it
> in trunk bzr 109859.
> 
>> What do you mean by different bzr versions?
> 
> I merely meant that the checkout wasn't consistent.
> This occasionally happens, if bzr is interrupted during
> a checkout.

Should not bzr status show this?

	Jan D.

Re: Change to bool only partially done?

[Eli Zaretskii]

> Date: Sun, 02 Sep 2012 07:36:16 -0700
> From: Paul Eggert <eggert@cs.ucla.edu>
> Cc: "emacs-devel@gnu.org" <emacs-devel@gnu.org>
> 
> I merely meant that the checkout wasn't consistent.
> This occasionally happens, if bzr is interrupted during
> a checkout.

If it happens, it's a bug in bzr that should be reported.  Updates
are atomic, they either complete successfully or not at all.  In
particular, AFAIU bzr updates the meta-data first, and only if that is
successful, updates the tree by using the meta-data locally.  So
partial file updates should never happen, except due to a bug (which
would be rather surprising at this stage in bzr development).