From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#12316: Simplify redefinition of 'abort'. Date: Fri, 31 Aug 2012 05:53:14 -0700 Organization: UCLA Computer Science Department Message-ID: <5040B3BA.6070108@cs.ucla.edu> References: <50402C2B.5020800@cs.ucla.edu> <833933qohs.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1346417645 9433 80.91.229.3 (31 Aug 2012 12:54:05 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 31 Aug 2012 12:54:05 +0000 (UTC) Cc: lekktu@gmail.com, 12316@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 31 14:54:06 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1T7QjV-0004qm-Pv for geb-bug-gnu-emacs@m.gmane.org; Fri, 31 Aug 2012 14:53:57 +0200 Original-Received: from localhost ([::1]:53767 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T7QjT-0003HC-IM for geb-bug-gnu-emacs@m.gmane.org; Fri, 31 Aug 2012 08:53:55 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:55602) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T7QjQ-0003Gq-GB for bug-gnu-emacs@gnu.org; Fri, 31 Aug 2012 08:53:53 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T7QjL-0007o7-Ot for bug-gnu-emacs@gnu.org; Fri, 31 Aug 2012 08:53:52 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:49703) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T7QjL-0007o3-LJ for bug-gnu-emacs@gnu.org; Fri, 31 Aug 2012 08:53:47 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1T7QkY-0000dc-8l for bug-gnu-emacs@gnu.org; Fri, 31 Aug 2012 08:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Paul Eggert Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 31 Aug 2012 12:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12316 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 12316-submit@debbugs.gnu.org id=B12316.13464176772415 (code B ref 12316); Fri, 31 Aug 2012 12:55:02 +0000 Original-Received: (at 12316) by debbugs.gnu.org; 31 Aug 2012 12:54:37 +0000 Original-Received: from localhost ([127.0.0.1]:59249 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T7Qk7-0000ct-R8 for submit@debbugs.gnu.org; Fri, 31 Aug 2012 08:54:36 -0400 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:56339) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T7Qk4-0000ck-Ra for 12316@debbugs.gnu.org; Fri, 31 Aug 2012 08:54:34 -0400 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 9225E39E800A; Fri, 31 Aug 2012 05:53:16 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Q8uz2FobqRAy; Fri, 31 Aug 2012 05:53:16 -0700 (PDT) Original-Received: from [192.168.1.3] (pool-108-23-119-2.lsanca.fios.verizon.net [108.23.119.2]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 1589239E8008; Fri, 31 Aug 2012 05:53:16 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux i686; rv:15.0) Gecko/20120827 Thunderbird/15.0 In-Reply-To: <833933qohs.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:63628 Archived-At: On 08/31/2012 04:39 AM, Eli Zaretskii wrote: > I don't understand what you want to happen after this change on > MS-Windows. Please explain more. Currently, MS-Windows defines a function w32_abort that implements the equivalent of 'abort' for MS-Windows. So .gdbinit calls w32_abort on MS-Windows, 'abort' on POSIX platforms, and nt/inc/ms-w32.h #defines abort to w32_abort and declares w32_abort. Due to the change, POSIX platforms define a function emacs_abort rather than replacing the system 'abort'. To keep in sync with that, the MS-Windows part of the patch renames w32_abort to emacs_abort. Hence .gdbinit can now call emacs_abort on all platforms, without a special case for MS-Windows, and nt/inc/ms-w32.h can remove its special declarations of w32_abort and of 'abort'. Also, this redefinition of 'abort' provides another reason why conf_post.h must include , which makes its comment about 'environ' confusing. To help remove this confusion I modified nt/inc/unistd.h to include ; this documents the fact that on POSIX platforms unistd.h declares 'environ', moving that documentation to the platform-specific area which is a better location for it.