From: Stuart Hickinbottom <stuart@hickinbottom.com>
To: emacs-orgmode@gnu.org
Subject: [PATCH] Fix org-clock evaluation startup hang on Windows
Date: Wed, 29 Aug 2012 12:25:39 +0100 [thread overview]
Message-ID: <503DFC33.70703@hickinbottom.com> (raw)
* lisp/org-clock.el (org-x11idle-exists-p): Only shell out when running
on X.
The definition of this variable currently executes "command" via the
shell during evaluation, irrespective of the platform on which
Org-mode is running. Unfortunately, on Windows, this matches the
"command.com" NT Virtual DOS Machine executable and so this gets
launched, but this is a shell and therefore sits there waiting for
user input and never returns. The net result is that Emacs will hang
on Windows when evaluating org-clock.el with the ntdvm.exe process
spinning at 100%.
The simple fix is to check that the platform is X before trying to
deal with the "x11idle" external process.
TINYCHANGE
---
lisp/org-clock.el | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lisp/org-clock.el b/lisp/org-clock.el
index 263f2cb..91f1c63 100644
--- a/lisp/org-clock.el
+++ b/lisp/org-clock.el
@@ -1001,7 +1001,8 @@ If `only-dangling-p' is non-nil, only ask to
resolve dangling
(defvar org-x11idle-exists-p
;; Check that x11idle exists
- (and (eq (call-process-shell-command "command" nil nil nil "-v"
"x11idle") 0)
+ (and (eq window-system 'x)
+ (eq (call-process-shell-command "command" nil nil nil "-v"
"x11idle") 0)
;; Check that x11idle can retrieve the idle time
(eq (call-process-shell-command "x11idle" nil nil nil) 0)))
--
1.7.11.4
--
Stuart Hickinbottom
next reply other threads:[~2012-08-29 11:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-29 11:25 Stuart Hickinbottom [this message]
2012-08-29 17:42 ` [PATCH] Fix org-clock evaluation startup hang on Windows Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=503DFC33.70703@hickinbottom.com \
--to=stuart@hickinbottom.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.