From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: /srv/bzr/emacs/trunk r109685: Rely on to declare 'environ' Date: Sun, 19 Aug 2012 21:05:47 -0700 Organization: UCLA Computer Science Department Message-ID: <5031B79B.1090005@cs.ucla.edu> References: <83d32mclxb.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1345435558 5720 80.91.229.3 (20 Aug 2012 04:05:58 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 20 Aug 2012 04:05:58 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 20 06:05:58 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1T3JFW-0006nw-B0 for ged-emacs-devel@m.gmane.org; Mon, 20 Aug 2012 06:05:58 +0200 Original-Received: from localhost ([::1]:59358 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3JFU-0008A2-RP for ged-emacs-devel@m.gmane.org; Mon, 20 Aug 2012 00:05:56 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:41275) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3JFR-00089m-U2 for emacs-devel@gnu.org; Mon, 20 Aug 2012 00:05:54 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T3JFR-0001vW-4T for emacs-devel@gnu.org; Mon, 20 Aug 2012 00:05:53 -0400 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:41380) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3JFP-0001rh-4C; Mon, 20 Aug 2012 00:05:51 -0400 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id D2C6139E800D; Sun, 19 Aug 2012 21:05:43 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FyBXGeuPVnSD; Sun, 19 Aug 2012 21:05:43 -0700 (PDT) Original-Received: from [192.168.1.3] (pool-108-23-119-2.lsanca.fios.verizon.net [108.23.119.2]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 7AB2639E8008; Sun, 19 Aug 2012 21:05:43 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux i686; rv:14.0) Gecko/20120714 Thunderbird/14.0 In-Reply-To: <83d32mclxb.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 131.179.128.62 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:152692 Archived-At: On 08/19/2012 07:54 PM, Eli Zaretskii wrote: > These parts of your changes seem to be wrong, or at least > under-documented in ChangeLog: the Windows build does not use > lib/unistd.h. On Windows, as I understand it, the system declares 'environ', so gnulib doesn't need to do anything special. I'm getting this info from gnulib's unistd.h file. It says that on Windows 'environ' is declared by stdlib.h. But Emacs's config.h includes stdlib.h, so 'environ' is always visible. I tried to clarify this by editing the ChangeLog in trunk bzr 109688. If my understanding is wrong, my apologies, but the point is that the main code should be able to assume that "#include " followed by "#include " declares 'environ', and if my analysis is incorrect and that's not the case then I suggest adding 'extern char **environ;' to nt/inc/unistd.h.