From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#12025: 24.1; Crash when using tootipshow Date: Thu, 16 Aug 2012 11:37:10 +0200 Message-ID: <502CBF46.3020602@gmx.at> References: <87liiba8ib.fsf@gmail.com> <83obn6z9ip.fsf@gnu.org> <878vdr6v4g.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1345109847 9946 80.91.229.3 (16 Aug 2012 09:37:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 16 Aug 2012 09:37:27 +0000 (UTC) Cc: 12025@debbugs.gnu.org, Thierry Volpiatto To: Chong Yidong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Aug 16 11:37:22 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1T1wVz-0005s5-En for geb-bug-gnu-emacs@m.gmane.org; Thu, 16 Aug 2012 11:37:19 +0200 Original-Received: from localhost ([::1]:36579 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1wVy-0004u4-9t for geb-bug-gnu-emacs@m.gmane.org; Thu, 16 Aug 2012 05:37:18 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:56875) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1wVv-0004th-UP for bug-gnu-emacs@gnu.org; Thu, 16 Aug 2012 05:37:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T1wVu-0002lo-Ch for bug-gnu-emacs@gnu.org; Thu, 16 Aug 2012 05:37:15 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:50986) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1wVu-0002ld-9J for bug-gnu-emacs@gnu.org; Thu, 16 Aug 2012 05:37:14 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1T1weQ-0000KO-01 for bug-gnu-emacs@gnu.org; Thu, 16 Aug 2012 05:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Aug 2012 09:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12025 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 12025-submit@debbugs.gnu.org id=B12025.13451103581250 (code B ref 12025); Thu, 16 Aug 2012 09:46:01 +0000 Original-Received: (at 12025) by debbugs.gnu.org; 16 Aug 2012 09:45:58 +0000 Original-Received: from localhost ([127.0.0.1]:60532 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T1weL-0000K6-8w for submit@debbugs.gnu.org; Thu, 16 Aug 2012 05:45:57 -0400 Original-Received: from mailout-de.gmx.net ([213.165.64.23]:41601) by debbugs.gnu.org with smtp (Exim 4.72) (envelope-from ) id 1T1weI-0000Jx-NS for 12025@debbugs.gnu.org; Thu, 16 Aug 2012 05:45:55 -0400 Original-Received: (qmail invoked by alias); 16 Aug 2012 09:37:04 -0000 Original-Received: from 62-47-56-184.adsl.highway.telekom.at (EHLO [62.47.56.184]) [62.47.56.184] by mail.gmx.net (mp001) with SMTP; 16 Aug 2012 11:37:04 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX19aDT8NH2BalXjUQnPiOgJUvtYeye+FoPsxCh+6bw s7XVUGfpEavY+z In-Reply-To: <878vdr6v4g.fsf@gnu.org> X-Y-GMX-Trusted: 0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:63225 > I guess the check is too aggressive. I moved it into the functions that > ought to signal an error if called on a window on a dead frame > (specifically window-edges, window-pixel-edges, > window-absolute-pixel-edges, delete-other-windows-internal, and > delete-window-internal). I now checked in a different fix which checks windows for validity. If we still see bugs/crashes these should come from either of two sources: (1) A not fully established frame. In this case we should avoid calling the function from there as I did with the Fset_window_buffer calls. (2) A dead frame. In this case there's a bug in the frame deletion routine which should render any window on that frame invalid and it's that part that has to be fixed. martin