From: Dmitry Antipov <dmantipov@yandex.ru>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Christoph Scholtes <cschol2112@googlemail.com>, 12007@debbugs.gnu.org
Subject: bug#12007: probably a fix
Date: Wed, 15 Aug 2012 20:34:17 +0400 [thread overview]
Message-ID: <502BCF89.9030600@yandex.ru> (raw)
In-Reply-To: <83r4rak33b.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 488 bytes --]
On 08/13/2012 11:24 PM, Eli Zaretskii wrote:
> Perhaps related, the current trunk (revision 109586) segfaults on
> startup ("emacs -Q") on GNU/Linux, with the following backtrace:
Eli, please review a fix.
This looks simple: it's wrong to look at with f->output_data.XXX without
checking f->output_method first, so, FRAME_X_OUTPUT (f) may be non-zero
for TTY frames, and segfault comes when xg_mark_data looks at initial
("F1") frame with non-zero f->output_data.tty member.
Dmitry
[-- Attachment #2: bug12007.patch --]
[-- Type: text/plain, Size: 435 bytes --]
=== modified file 'src/gtkutil.c'
--- src/gtkutil.c 2012-08-15 09:40:00 +0000
+++ src/gtkutil.c 2012-08-15 16:22:28 +0000
@@ -2259,7 +2259,7 @@
{
FRAME_PTR f = XFRAME (frame);
- if (FRAME_X_OUTPUT (f) && FRAME_GTK_OUTER_WIDGET (f))
+ if (FRAME_X_P (f) && FRAME_GTK_OUTER_WIDGET (f))
{
struct xg_frame_tb_info *tbinfo
= g_object_get_data (G_OBJECT (FRAME_GTK_OUTER_WIDGET (f)),
next prev parent reply other threads:[~2012-08-15 16:34 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-21 13:17 bug#12007: 24.1.50; Crash in auto-revert-handler Christoph Scholtes
2012-07-21 13:51 ` Eli Zaretskii
2012-07-21 22:22 ` Christoph Scholtes
2012-07-25 0:39 ` Christoph Scholtes
2012-07-25 2:37 ` Dmitry Antipov
2012-07-25 2:37 ` Dmitry Antipov
2012-07-25 3:53 ` Christoph Scholtes
2012-07-25 4:42 ` Dmitry Antipov
2012-07-25 4:42 ` Dmitry Antipov
2012-07-25 11:34 ` Christoph Scholtes
2012-07-25 11:34 ` Christoph Scholtes
2012-07-25 12:39 ` Dmitry Antipov
2012-08-13 19:03 ` Christoph Scholtes
2012-08-13 19:24 ` Eli Zaretskii
2012-08-14 2:52 ` Eli Zaretskii
2012-08-15 14:55 ` Dmitry Antipov
2012-08-15 15:08 ` Drew Adams
2012-08-15 15:08 ` Drew Adams
2012-08-15 17:05 ` Eli Zaretskii
2012-08-15 14:55 ` Dmitry Antipov
2012-08-15 16:34 ` Dmitry Antipov [this message]
2012-08-15 16:40 ` Eli Zaretskii
2012-08-15 16:50 ` Dmitry Antipov
2012-08-15 17:27 ` Eli Zaretskii
2012-08-15 18:35 ` Jan Djärv
2012-07-25 12:39 ` Dmitry Antipov
2012-07-22 4:11 ` Dmitry Antipov
2012-07-22 17:46 ` Christoph Scholtes
2012-07-22 19:50 ` Andreas Schwab
2012-07-22 20:50 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502BCF89.9030600@yandex.ru \
--to=dmantipov@yandex.ru \
--cc=12007@debbugs.gnu.org \
--cc=cschol2112@googlemail.com \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.