From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#6286: General delimited literals in ruby-mode patch Date: Tue, 14 Aug 2012 21:46:48 +0400 Message-ID: <502A8F08.8010406@yandex.ru> References: <8739ammd8l.fsf@yandex.ru> <87k43vecyt.fsf@yandex.ru> <4F973B73.1000808@yandex.ru> <4F981DEA.6060700@yandex.ru> <4FA21A1C.8040907@yandex.ru> <5029CC7A.4060001@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1344966451 16925 80.91.229.3 (14 Aug 2012 17:47:31 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 14 Aug 2012 17:47:31 +0000 (UTC) Cc: 6286@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Aug 14 19:47:30 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1T1LDE-0000Ey-Rb for geb-bug-gnu-emacs@m.gmane.org; Tue, 14 Aug 2012 19:47:29 +0200 Original-Received: from localhost ([::1]:53299 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1LDE-00034E-09 for geb-bug-gnu-emacs@m.gmane.org; Tue, 14 Aug 2012 13:47:28 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:54619) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1LDA-00033S-LY for bug-gnu-emacs@gnu.org; Tue, 14 Aug 2012 13:47:25 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T1LD9-00049N-HW for bug-gnu-emacs@gnu.org; Tue, 14 Aug 2012 13:47:24 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:47216) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1LD9-00049H-9Q for bug-gnu-emacs@gnu.org; Tue, 14 Aug 2012 13:47:23 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1T1LLV-0006I5-Pa for bug-gnu-emacs@gnu.org; Tue, 14 Aug 2012 13:56:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 Aug 2012 17:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6286 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 6286-submit@debbugs.gnu.org id=B6286.134496693224141 (code B ref 6286); Tue, 14 Aug 2012 17:56:01 +0000 Original-Received: (at 6286) by debbugs.gnu.org; 14 Aug 2012 17:55:32 +0000 Original-Received: from localhost ([127.0.0.1]:56762 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T1LL1-0006HK-Fh for submit@debbugs.gnu.org; Tue, 14 Aug 2012 13:55:32 -0400 Original-Received: from forward10.mail.yandex.net ([77.88.61.49]:42423) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1T1LKy-0006HB-OU for 6286@debbugs.gnu.org; Tue, 14 Aug 2012 13:55:30 -0400 Original-Received: from smtp8.mail.yandex.net (smtp8.mail.yandex.net [77.88.61.54]) by forward10.mail.yandex.net (Yandex) with ESMTP id 6E9121022326; Tue, 14 Aug 2012 21:46:48 +0400 (MSK) Original-Received: from smtp8.mail.yandex.net (localhost [127.0.0.1]) by smtp8.mail.yandex.net (Yandex) with ESMTP id 4C2A91B60788; Tue, 14 Aug 2012 21:46:48 +0400 (MSK) Original-Received: from dynamicip-188-187-120-34.pppoe.volgograd.ertelecom.ru (dynamicip-188-187-120-34.pppoe.volgograd.ertelecom.ru [188.187.120.34]) by smtp8.mail.yandex.net (nwsmtp/Yandex) with ESMTP id kl2qufbJ-kl2eofZS; Tue, 14 Aug 2012 21:46:48 +0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1344966408; bh=qReu7/2WGT4AForPt7PtzFcJPUt+qNj0ilBcGXnb40c=; h=Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject: References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=QtIgLY2W7qdgLAbwbS0TEZ+a3CumrgVdfZHmQTI43zuZPHvb8aCt0m+a2xRo+1a2b g3iTfUe2SQcpZIgMaHdskPca2ePNnyP6vPsv92IulJob3EExSvIRW3wMbY2BxhhLRo 9gwB9WtT9e3P8ZvQQsovcCUucFhG0EGUr1foG5B8= User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:14.0) Gecko/20120713 Thunderbird/14.0 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:63171 Archived-At: On 14.08.2012 16:40, Stefan Monnier wrote: > I kind of remember something about this second case, and remember being > bothered by the fact that ruby-syntax-methods-before-regexp would need > to be adjusted by the user since it can depend on its locale > (especially the Given/Then/When). While Cucumber features can be localized, ruby-mode should only be used with step definitions [1], and those just contain Ruby code, so the Given/Then/When method names would be the same, AFAIK. A user might want to be able to add a new method to the list, theoretically, but paren-less calling convention is mostly used in DSL-like code (that means, with methods provided by some framework or other), so I say we wait until such feature request actually comes. > I also vaguely remember that this problem was related to the reason why > I added the "look after the regexp" test. That was in the original patch I submitted, mostly because it looked like a clever solution. But the conservative approach should work, too: the canonical (I think) TextMate bundle uses the whitelist [2] without major complaints. > It would probably be better if you could commit those changes yourself. > If you want to do that, please request membership in the "emacs" group > from your savannah account (which you may have to create beforehand). Requested, thanks. I think we're finished with this bug, though, unless you'd like to see some other changes. --Dmitry [1] https://github.com/cucumber/cucumber/wiki/Step-Definitions [2] https://github.com/drnic/ruby-tmbundle/blob/master/Syntaxes/Ruby.plist#L882