all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 6286@debbugs.gnu.org
Subject: bug#6286: General delimited literals in ruby-mode patch
Date: Tue, 14 Aug 2012 21:46:48 +0400	[thread overview]
Message-ID: <502A8F08.8010406@yandex.ru> (raw)
In-Reply-To: <jwvtxw5u0c8.fsf-monnier+emacs@gnu.org>

On 14.08.2012 16:40, Stefan Monnier wrote:
> I kind of remember something about this second case, and remember being
> bothered by the fact that ruby-syntax-methods-before-regexp would need
> to be adjusted by the user since it can depend on its locale
> (especially the Given/Then/When).

While Cucumber features can be localized, ruby-mode should only be used 
with step definitions [1], and those just contain Ruby code, so the 
Given/Then/When method names would be the same, AFAIK.

A user might want to be able to add a new method to the list, 
theoretically, but paren-less calling convention is mostly used in 
DSL-like code (that means, with methods provided by some framework or 
other), so I say we wait until such feature request actually comes.

> I also vaguely remember that this problem was related to the reason why
> I added the "look after the regexp" test.

That was in the original patch I submitted, mostly because it looked 
like a clever solution. But the conservative approach should work, too: 
the canonical (I think) TextMate bundle uses the whitelist [2] without 
major complaints.

> It would probably be better if you could commit those changes yourself.
> If you want to do that, please request membership in the "emacs" group
> from your savannah account (which you may have to create beforehand).

Requested, thanks.

I think we're finished with this bug, though, unless you'd like to see 
some other changes.

--Dmitry

[1] https://github.com/cucumber/cucumber/wiki/Step-Definitions
[2] 
https://github.com/drnic/ruby-tmbundle/blob/master/Syntaxes/Ruby.plist#L882





  reply	other threads:[~2012-08-14 17:46 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-07 23:32 General delimited literals in ruby-mode patch Dmitry Gutov
2012-02-10  0:42 ` Dmitry Gutov
2012-02-10  5:03   ` Dmitry Gutov
2012-04-24 17:09     ` bug#6286: " Stefan Monnier
2012-04-25  3:03       ` Dmitry Gutov
2012-04-24 15:43   ` Stefan Monnier
2012-04-24 23:46     ` Dmitry Gutov
2012-04-25 14:15       ` Stefan Monnier
     [not found]         ` <4F981DEA.6060700@yandex.ru>
     [not found]           ` <jwv4ns7iubj.fsf-monnier+emacs@gnu.org>
2012-04-28 20:20             ` Dmitry Gutov
2012-05-03  5:39             ` Dmitry Gutov
2012-08-14  3:56               ` Dmitry Gutov
2012-08-14 12:40                 ` Stefan Monnier
2012-08-14 17:46                   ` Dmitry Gutov [this message]
2012-08-15  2:33                     ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=502A8F08.8010406@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=6286@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.