From: martin rudalics <rudalics@gmx.at>
To: Bill Brodie <wbrodie@panix.com>
Cc: 12170@debbugs.gnu.org
Subject: bug#12170: save-excursion fails boundary case with recenter
Date: Fri, 10 Aug 2012 16:47:09 +0200 [thread overview]
Message-ID: <50251EED.3010804@gmx.at> (raw)
In-Reply-To: <003601cd76fd$b21cd590$165680b0$@com>
> (1) By "window height", I meant the number of lines displayed for the actual
> buffer, not counting the mode line or minibuffer. It turns out this is one
> less than the value returned by `window-height'.
>
> (2) The value of `point' changes (the cursor "hops", in other words) when
> the window is redisplayed, or when control returns to the user.
>
> Here is code that will produce the bug (with emacs -Q):
>
> (progn
> (defun f (n)
> (save-excursion (forward-line (- n)) (recenter 0)))
> (let ((buffer (switch-to-buffer "foo"))
> (height (1- (window-height (get-buffer-window "foo")))))
> (insert-char 10 (* height 2))
> (let ((pt (point)))
> (f height)
> (redisplay)
> (message "height %s old %s new %s" height pt (point)))))
>
> If you leave out the `redisplay' call, on the other hand, old = new in the
> message -- but after control returns to the user, point has still been moved
> in the buffer.
I see it now, thanks. Surprisingly it doesn't show up with code like
(progn
(defmacro save-this-window-excursion (&rest body)
"..."
(let ((start (make-symbol "start"))
(point (make-symbol "point")))
`(let ((,start (copy-marker (window-start)))
(,point (copy-marker (window-point))))
(save-selected-window
(progn ,@body))
(set-window-start (selected-window) ,start t)
(set-window-point (selected-window) ,point))))
(defun f (n)
(save-this-window-excursion (forward-line (- n)) (recenter 0)))
(let ((buffer (switch-to-buffer "foo"))
(height (1- (window-height (get-buffer-window "foo")))))
(insert-char 10 (* height 2))
(let ((pt (point)))
(f height)
(redisplay)
(message "height %s old %s new %s" height pt (point)))))
so I'd suspect the culprit somewhere in redisplay_window's code
if (w->optional_new_start
w->optional_new_start is 1 from `recenter'
&& CHARPOS (startp) >= BEGV
&& CHARPOS (startp) <= ZV)
{
w->optional_new_start = 0;
start_display (&it, w, startp);
move_it_to (&it, PT, 0, it.last_visible_y, -1,
MOVE_TO_POS | MOVE_TO_X | MOVE_TO_Y);
if (IT_CHARPOS (it) == PT)
w->force_start = 1;
/* IT may overshoot PT if text at PT is invisible. */
else if (IT_CHARPOS (it) > PT && CHARPOS (startp) <= PT)
w->force_start = 1;
w->force_start 1 will cause redisplay to honor the start position set up
by `recenter' despite of save_excursion_restore's Fgoto_char.
}
But I don't have the slightest idea how calling
(set-window-start (selected-window) ,start t)
would remedy this. Eli will soon teach us a lesson here.
martin
next prev parent reply other threads:[~2012-08-10 14:47 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-10 1:23 bug#12170: save-excursion fails boundary case with recenter Bill Brodie
2012-08-10 9:34 ` martin rudalics
2012-08-10 9:50 ` Bastien
2012-08-10 13:03 ` martin rudalics
2012-08-10 13:40 ` Bill Brodie
2012-08-10 14:47 ` martin rudalics [this message]
2012-08-10 16:18 ` Stefan Monnier
2012-08-10 16:47 ` martin rudalics
2012-08-10 17:07 ` Stefan Monnier
2012-08-10 19:01 ` Eli Zaretskii
2012-08-11 9:32 ` martin rudalics
2012-08-11 11:11 ` Eli Zaretskii
2012-08-11 14:22 ` martin rudalics
2012-08-11 15:10 ` Eli Zaretskii
2012-08-11 16:05 ` martin rudalics
2012-08-11 16:31 ` Eli Zaretskii
2012-08-11 16:49 ` Eli Zaretskii
2012-08-12 10:31 ` martin rudalics
2012-08-11 16:27 ` Bill Brodie
2012-08-10 15:04 ` Stefan Monnier
2012-08-10 15:46 ` Bill Brodie
2012-08-10 16:46 ` martin rudalics
2012-08-10 16:46 ` martin rudalics
2012-08-10 18:58 ` Eli Zaretskii
2012-08-11 9:31 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50251EED.3010804@gmx.at \
--to=rudalics@gmx.at \
--cc=12170@debbugs.gnu.org \
--cc=wbrodie@panix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.