From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] propose to add vundo.el to ELPA Date: Thu, 7 Apr 2022 17:43:17 -0700 Message-ID: <502340B0-F6AD-43FB-8C0F-08F88F618919@gmail.com> References: <15F35A7C-7A15-4B1E-8959-612C10166242@gmail.com> <875ynonqmc.fsf@web.de> <87h774xzzw.fsf@web.de> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.80.82.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35486"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Michael Heerdegen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Apr 08 02:44:57 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ncckC-00096X-Ud for ged-emacs-devel@m.gmane-mx.org; Fri, 08 Apr 2022 02:44:56 +0200 Original-Received: from localhost ([::1]:40230 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ncckB-0006aX-DD for ged-emacs-devel@m.gmane-mx.org; Thu, 07 Apr 2022 20:44:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45062) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nccit-0005s1-A1 for emacs-devel@gnu.org; Thu, 07 Apr 2022 20:43:35 -0400 Original-Received: from mail-pf1-x42d.google.com ([2607:f8b0:4864:20::42d]:37868) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ncciq-0007wX-Q2 for emacs-devel@gnu.org; Thu, 07 Apr 2022 20:43:34 -0400 Original-Received: by mail-pf1-x42d.google.com with SMTP id bo5so7043110pfb.4 for ; Thu, 07 Apr 2022 17:43:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=rurunMkaNjJPyE3o+jBIqO19SSxze88KB988z6EZ9hc=; b=RWsNsaAqAnDZ3EoyadkWifaNyxVbRsjUE0Go+cOVLijFBGVeiJdQQ4GKFVsN3AlVpH edNM0xZ4dKGVX0/lzUlVLMf/UOyQiS4kp/t6CcNVmy+NHT9ESqQUScOZOIAtNaWYlt4w 9j85W/dB7AsK+Um2rJmRFpM1llKwBlKIz8f7yYjmkhCBMMYk621jmb8n5mEoOlk6TsnB YnSXQx4ObYiskSJowYnNcyu8RvASj4rvWOSiugUKYfIAWIFwkpMKgWFQLU+sCQjHZrm9 m4oQ1OqK2X3Nw0ngy3/73q8QrU4jV11E4FANm3fmDyORZnhMfQ9b/AmgeWT6TQYt5vQS 7e3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=rurunMkaNjJPyE3o+jBIqO19SSxze88KB988z6EZ9hc=; b=JmUc2dyFl4HEABeRYK0vWe6ryqgmoB1E/szqaeliAdePSlB55MuESY1iJJm/wguf8N afKwcGReUN4qziRiX4HuqTtl7YBDvM5boNCMXYfl8LuWynlYGM/Ws8JgVIo0fUD/lmH9 3wzedA0VnrlzRl3JsMsK0xWSU4iRlP8+bjJ3koEczRq53cOQJDbXBIoQVNJ1pBQaAL4Y +0O8BXjgO275cq+G5fUuQy2Ko4GUIRdNfeb40tEczWzYOLhJt8h3bw9FxKmsM9WdtAGC o2TjpzUjg2JrlNJFykLo9K/7jl1hqWKUuyC/FtcZ9ragYF6zQBivRFHvTpQNnJPm4PUp 4pHg== X-Gm-Message-State: AOAM533DDGm54DDw9mD1iVgZvWNkm6ojPdPT+/F5xNUF8BG3qzf/OerH YN6jDPeDWByszNkqKK1rxDE= X-Google-Smtp-Source: ABdhPJzR0iWpfxnWdnoV7WyPBLMt2mkhqN6E8XMeeUz2K04Z3Sqbv4TYncxBoRkpWdDitd3WLOib0Q== X-Received: by 2002:a05:6a00:24c6:b0:4fd:9038:74f0 with SMTP id d6-20020a056a0024c600b004fd903874f0mr16926023pfv.63.1649378599155; Thu, 07 Apr 2022 17:43:19 -0700 (PDT) Original-Received: from smtpclient.apple ([128.54.44.79]) by smtp.gmail.com with ESMTPSA id b13-20020a056a00114d00b004c122b90703sm23685032pfm.27.2022.04.07.17.43.18 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Apr 2022 17:43:18 -0700 (PDT) In-Reply-To: <87h774xzzw.fsf@web.de> X-Mailer: Apple Mail (2.3696.80.82.1.1) Received-SPF: pass client-ip=2607:f8b0:4864:20::42d; envelope-from=casouri@gmail.com; helo=mail-pf1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287911 Archived-At: >=20 > Ok, 3 little more: >=20 Thanks, merged. >=20 > Some more ideas/thoughts: >=20 > (1) If you use `vundo' for the first time in a buffer with an already > very large undo list, do you expect a delay? Would it make sense to > limit the processing of `buffer-undo-list' to the last N entries to > avoid such a delay (N would probably be a user option)? That depends on exactly how large the undo list is. For any daily = workload vundo is pretty fast. For super long undo lists there is a = delay but not too bad. I just tried 1k and 10k entries, 1k took ~0.3s, = 10k took ~3s. >=20 > (2) I wonder which setup I will prefer in the future. I'm using the > commands that already "fold" the undo list (AFAIU, in the same or a > similar sense as vundo does): `undo-only' and `undo-redo'. Do these > commands directly correspond to hitting right and left in the vundo > buffer? Pretty much. They don=E2=80=99t run the same code but the semantics = should be the same. I use undo-only and undo-redo myself. >=20 > If yes, I think it would be cool to setup stuff that the keys I use = for > `undo-only' and `undo-redo' would work like now but additionally start > vundo. And the same keys would still work in vundo and call > vundo-backward and vundo-forwar, additionally to the existing = bindings. > I think that could feel convenient. Would such a setup make sense to > you? I never feel the need to see the undo tree when I=E2=80=99m just doing = simple undo. You can definitely try it using transient keymaps Yuan=