From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Antipov Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r109512: Inline functions to examine and change buffer overlays. Date: Wed, 08 Aug 2012 20:26:55 +0400 Message-ID: <5022934F.3050702@yandex.ru> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1344443224 1043 80.91.229.3 (8 Aug 2012 16:27:04 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 8 Aug 2012 16:27:04 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Aug 08 18:27:05 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Sz967-0000u1-Ll for ged-emacs-devel@m.gmane.org; Wed, 08 Aug 2012 18:27:03 +0200 Original-Received: from localhost ([::1]:43855 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sz966-0002Y1-Uo for ged-emacs-devel@m.gmane.org; Wed, 08 Aug 2012 12:27:02 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:39124) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sz964-0002Xu-CD for emacs-devel@gnu.org; Wed, 08 Aug 2012 12:27:01 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sz963-0001Eu-FE for emacs-devel@gnu.org; Wed, 08 Aug 2012 12:27:00 -0400 Original-Received: from forward9.mail.yandex.net ([77.88.61.48]:54531) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sz963-0001Ei-36 for emacs-devel@gnu.org; Wed, 08 Aug 2012 12:26:59 -0400 Original-Received: from smtp9.mail.yandex.net (smtp9.mail.yandex.net [77.88.61.35]) by forward9.mail.yandex.net (Yandex) with ESMTP id 7402ACE2116; Wed, 8 Aug 2012 20:26:57 +0400 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1344443217; bh=J+GKwzd4z2wbSPfZrBPpgUh5x0Ahf7RVy/y0dstXADg=; h=Message-ID:Date:From:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=LEX1sncQwEYeP4l4eY95HyxYM0616RR8XlTEbb9SCf0Z+vkX/N1G+OMcNInzrkCXH fedorG1SYv3tfNRxYLQvAhYjraQNrEfMPAN3qyrPEQd4T4QLUgZRTaO1kiYJu7iHoh DDx8TFEtyIgt5z4AGJUMIgrjApz3iAnFHlE39RYE= Original-Received: from smtp9.mail.yandex.net (localhost [127.0.0.1]) by smtp9.mail.yandex.net (Yandex) with ESMTP id 519FA15203E4; Wed, 8 Aug 2012 20:26:57 +0400 (MSK) Original-Received: from 103.gprs.mts.ru (103.gprs.mts.ru [213.87.131.103]) by smtp9.mail.yandex.net (nwsmtp/Yandex) with ESMTP id Qtl0BeWq-Qul0r35b; Wed, 8 Aug 2012 20:26:56 +0400 X-Yandex-Rcpt-Suid: monnier@iro.umontreal.ca X-Yandex-Rcpt-Suid: emacs-devel@gnu.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1344443217; bh=J+GKwzd4z2wbSPfZrBPpgUh5x0Ahf7RVy/y0dstXADg=; h=Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject: References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=KRmdeSFJxfFkHyhzzhUqyXSf8OjgNDs6UaJPyeZ2QbJy14oCkHq/xMgnKc3/Sr6DU vo4Xlg7pqnJJ3xFmaEqb0zIruoAeXZspJKVjIulhu3YdGL+eU+m3QG63hfCcuY8iS5 xDlgx3PBcDVjPOAPixR6tl75fLfsCNOMf7Iw2vgw= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120713 Thunderbird/14.0 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 77.88.61.48 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:152342 Archived-At: On 08/08/2012 07:45 PM, Stefan Monnier wrote: > Can we pause for a moment? > As I mentioned to you earlier, you should post such patches for review > before installing them. > And explain why you think they're good. > E.g. replacing buffer->overlays_before by "buffer_get_overlays (buffer, > OV_BEFORE)" is far from "obviously good" in my eyes. > If you intend to make those field accesses into something more complex, > then please say so and explain why. If not, then please stick to > "foo->bar", as agreed for the FGET case. I think that it's reasonable to have just one chain of overlays per buffer, much like the markers and intervals chains per buffer text. And buffer_get_overlays(b, WHAT) is expected to simplify transition to this possible change. Dmitry