From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Antipov Newsgroups: gmane.emacs.devel Subject: Re: Refactoring in Emacs Date: Wed, 01 Aug 2012 08:14:47 +0400 Message-ID: <5018AD37.1000509@yandex.ru> References: <5017D1D4.2050601@yandex.ru> <83wr1jeua9.fsf@gnu.org> <50181914.4030503@yandex.ru> <83pq7berfa.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1343794501 14470 80.91.229.3 (1 Aug 2012 04:15:01 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 1 Aug 2012 04:15:01 +0000 (UTC) Cc: joakim@verona.se, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Aug 01 06:15:01 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SwQKo-0001uc-Bk for ged-emacs-devel@m.gmane.org; Wed, 01 Aug 2012 06:14:58 +0200 Original-Received: from localhost ([::1]:45465 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwQKn-0003DF-5t for ged-emacs-devel@m.gmane.org; Wed, 01 Aug 2012 00:14:57 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:38371) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwQKk-0003D2-9k for emacs-devel@gnu.org; Wed, 01 Aug 2012 00:14:55 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SwQKj-0000cY-CB for emacs-devel@gnu.org; Wed, 01 Aug 2012 00:14:54 -0400 Original-Received: from forward3h.mail.yandex.net ([84.201.187.148]:48555) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SwQKh-0000cE-Ci; Wed, 01 Aug 2012 00:14:51 -0400 Original-Received: from smtp1h.mail.yandex.net (smtp1h.mail.yandex.net [84.201.187.144]) by forward3h.mail.yandex.net (Yandex) with ESMTP id 7DFF71362CC6; Wed, 1 Aug 2012 08:14:49 +0400 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1343794489; bh=Un4IBOOcOPnaH4/1OY7kHAXkxqGBa+IsRPeJfVwYnXw=; h=Message-ID:Date:From:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=d1mFH7OAANCAWba/7shIjnUjHSuXOeuUmXJWUB2zp2aeDBGrhr3CZ7JQXRrgiA1Ow x4Q6ETcrlyaeR3Pj9a5WkQmwtDcR38ryAJn5HjXUVLv01G370y9ZscY3lB/lF/7kVV UbbYy2/uNbiu8GgR3qjgp0ougfvltmTs5BI6bVh0= Original-Received: from smtp1h.mail.yandex.net (localhost [127.0.0.1]) by smtp1h.mail.yandex.net (Yandex) with ESMTP id 2880F13402C7; Wed, 1 Aug 2012 08:14:49 +0400 (MSK) Original-Received: from 231.gprs.mts.ru (231.gprs.mts.ru [213.87.133.231]) by smtp1h.mail.yandex.net (nwsmtp/Yandex) with ESMTP id ElwCBs7w-EmwOtK8w; Wed, 1 Aug 2012 08:14:48 +0400 X-Yandex-Rcpt-Suid: eliz@gnu.org X-Yandex-Rcpt-Suid: joakim@verona.se X-Yandex-Rcpt-Suid: emacs-devel@gnu.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1343794489; bh=Un4IBOOcOPnaH4/1OY7kHAXkxqGBa+IsRPeJfVwYnXw=; h=Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject: References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=Sb7e8eI6CxNs2nsfifEYX+3gxqEb6Kx4aSf4E9IILaMHkEiTdCLRbEXiEfO0h3g0e mi6ChEb6vWTMy0kFcifFYxYiQeXmGNQCJF2KVsh5qOM1JC56sbGNLa89DZIYfQoGoG RKfJnugRrlfIpDGtP3oXl6FQI854U+cV2ks4pgEs= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120713 Thunderbird/14.0 In-Reply-To: <83pq7berfa.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 84.201.187.148 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:152061 Archived-At: On 07/31/2012 10:06 PM, Eli Zaretskii wrote: >> IIUC real refactoring of C should imply preprocessing and full >> syntactic analysis > > Why is that? Can you give a couple of examples? It's easy to use regexps to make foo (2, 1); from foo (1, 2); But it may be very tricky or even impossible to do the same for: 1) foo (bar (x, y, z), baz (a, b, c)); 2) foo (bar (x, y, foo (z, 1)), baz (foo (a, b) > 0 ? c : d, e, f)); 3) foo ( #ifdef AAA a, #else b, #endif c > 0 ? c : -c); etc. For 2), syntax tree may looks like: ++++++++++++[foo]++++++++++++ + + +++[bar]+++ ++++++[baz]++++++ + + + + + + x y +[foo]+ ++++[> ?]++++ e f + + + + + z 1 +[foo]+ c d + + a b So, refactoring is (hm, relatively) simple: you should traverse the tree, look for +[foo]+ + + x y pattern and swap subtrees. Check http://gcc-melt.org, it looks very similar to what I'm thinking about. Dmitry