From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#68929: which-key tests from GNU ELPA into core Date: Mon, 15 Apr 2024 10:39:33 +0200 Message-ID: <50125497-B489-4541-81A1-3DC1F1F9D6A3@gmail.com> References: <87zfvl8r4e.fsf@jeremybryant.net> <874jdspsqb.fsf@bernoul.li> <877cio8fzf.fsf@jeremybryant.net> <87o7bkcrnq.fsf@jeremybryant.net> <87r0fugl5o.fsf@jeremybryant.net> <87h6g6jthh.fsf@jeremybryant.net> <87edb7zjz3.fsf@jeremybryant.net> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37119"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 68929@debbugs.gnu.org, Justin Burkett To: Jeremy Bryant Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Apr 15 10:40:12 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rwHsq-0009Mk-Aj for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 15 Apr 2024 10:40:12 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rwHsW-0005ik-Ei; Mon, 15 Apr 2024 04:39:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rwHsV-0005iE-6A for bug-gnu-emacs@gnu.org; Mon, 15 Apr 2024 04:39:51 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rwHsU-00008z-Sy for bug-gnu-emacs@gnu.org; Mon, 15 Apr 2024 04:39:50 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rwHsg-0000KQ-8J for bug-gnu-emacs@gnu.org; Mon, 15 Apr 2024 04:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 Apr 2024 08:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68929 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 68929-submit@debbugs.gnu.org id=B68929.17131703951245 (code B ref 68929); Mon, 15 Apr 2024 08:40:02 +0000 Original-Received: (at 68929) by debbugs.gnu.org; 15 Apr 2024 08:39:55 +0000 Original-Received: from localhost ([127.0.0.1]:36649 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rwHsY-0000K1-Nn for submit@debbugs.gnu.org; Mon, 15 Apr 2024 04:39:55 -0400 Original-Received: from mail-lf1-x12b.google.com ([2a00:1450:4864:20::12b]:60626) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rwHsW-0000Im-TZ for 68929@debbugs.gnu.org; Mon, 15 Apr 2024 04:39:53 -0400 Original-Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-516d727074eso3744593e87.0 for <68929@debbugs.gnu.org>; Mon, 15 Apr 2024 01:39:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713170375; x=1713775175; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=ibUWb8V8nLDAM/21Xnq9q4/OLVm5aPU80N7r/Fh/J4E=; b=JDVtFet6nTCvqAbTxngr+3DkMVawVBp/YDjZWlzZHo16J+5h49I+WsvTXyEzcDmuPK LNeRqCuwyt0FZZFZGoRcGvtF8Quj7Js4dr5UHIyz9CDiZQ9mjjgyyrEIZd6cpxDH/5If j3K0cx3DHO68pTrwsF0oWirPifZZZ57zjAlnnt5E8PEmuX6cHyEsCG+wq00SdFQIA4el 98w8IqPvhNAEfurQXptsTbHprBay070NBCZrpMYDpTBosNiwfMC6ojtlmWG2p586U7wz tHPGps2UhXT6yBVmW93FovUNhmaieOITiaLaPe8ach3O8IevjBAp3UxdOl8bfzNr7dd8 EMCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713170375; x=1713775175; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ibUWb8V8nLDAM/21Xnq9q4/OLVm5aPU80N7r/Fh/J4E=; b=cd7nSky5WK+ZS5YsM8rmFkRef5aelIL09GU4Osh8B/gRoF1rdkXKAyeTcCZIft3B2f sR2oSHeUHCUxDf+0xRVHtQN2JOdPh62Ul0xKXyHBtnHiw2jxeB3BPrUz7SyTLXvz7BUe fSoU0Mdug8UJbbeuJY1xJTqrQWPolBp3dUgiDMssCMcCFfHeSSbdio7ZqfdM63EcdI6r IbmHcZsCpZr4oeG/U8td+OjMIuiKTX/+EsxsDvztJCVyecl4UVWDsAe67c9PCi0slPAW mrxMTwfruwvfE4wmLFFIeIYqiWzZAwB7kVHb+yYjjov7JDC18QDadRSwGGn9czPx9ePo 7rLg== X-Gm-Message-State: AOJu0Yw4pZkjsfAbn7NXoMSHZlPLtTJpnFD3GqGB5+DS4H5V68/rlcmX Dcu+6X7g9BPW4n7uE2Zs2n1b2OJjNtZcx4nG7eA+klO2J0XL9Pp/OJS35w== X-Google-Smtp-Source: AGHT+IERg3F+VGefswzLX8BhmWlCGh7QqH8HUQFP2qCmMg+tYc953yqdrIeGqdOOvUZHfqN7CqWRCA== X-Received: by 2002:a05:6512:ac6:b0:518:df4b:40e9 with SMTP id n6-20020a0565120ac600b00518df4b40e9mr2137681lfu.4.1713170374981; Mon, 15 Apr 2024 01:39:34 -0700 (PDT) Original-Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se. [80.217.1.132]) by smtp.gmail.com with ESMTPSA id z18-20020a056512371200b00518cf9ca6besm375868lfr.232.2024.04.15.01.39.34 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 15 Apr 2024 01:39:34 -0700 (PDT) In-Reply-To: <87edb7zjz3.fsf@jeremybryant.net> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:283348 Archived-At: 14 apr. 2024 kl. 23.56 skrev Jeremy Bryant : > Mattias, > I understand you have expertise on the testing infrastructure, do you > have any comments on any work required to change this file or would it > be good to go 'as is'? Well it looks all right as far as I can tell from a quick glance, but = you are the one with domain knowledge here. =46rom the dept. of unimportant details: you may want to update the = copyright year, and bug references such as "#109" could perhaps be = annotated so that it's clear where to look (maybe use the full URL).