From: Dmitry Antipov <dmantipov@yandex.ru>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r109187: Adjust consing_since_gc when objects are explicitly freed.
Date: Wed, 25 Jul 2012 13:55:59 +0400 [thread overview]
Message-ID: <500FC2AF.9080300@yandex.ru> (raw)
In-Reply-To: <jwvtxwwes8u.fsf-monnier+emacs@gnu.org>
On 07/25/2012 01:59 AM, Stefan Monnier wrote:
> What about the overall running time. How much is saved by your patch,
> and how much additional is saved by the "decrement consing_since_gc in
> free_marker"?
Hm. The test is:
(defun scroll-benchmark ()
(interactive)
(let ((oldgc gcs-done)
(oldtime (float-time)))
(condition-case nil (while t (scroll-up) (redisplay))
(error (message "GCs: %d Elapsed time: %f seconds"
(- gcs-done oldgc) (- (float-time) oldtime))))))
For xdisp.c, the original results are 600 GCs and 32.65 seconds.
When free_cons and free_misc subtracts from consing_since_gc,
and save_restriction_restore frees it's data explicitly, results
are 560 GCs and 31.95 seconds.
Of course, explicit free in save_restriction_restore makes no sense
if we fool GC with consing_since_gc: 600 GCs and 32.95 seconds.
I don't understand why we're still wast^W^Wspending our time with
such a simple and almost obvious thing.
Dmitry
next prev parent reply other threads:[~2012-07-25 9:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1SsxuH-00048I-6E@vcs.savannah.gnu.org>
2012-07-23 8:58 ` [Emacs-diffs] /srv/bzr/emacs/trunk r109187: Adjust consing_since_gc when objects are explicitly freed Stefan Monnier
2012-07-23 9:26 ` Dmitry Antipov
2012-07-23 10:06 ` Stefan Monnier
2012-07-23 11:34 ` Dmitry Antipov
2012-07-23 23:11 ` Stefan Monnier
2012-07-24 4:30 ` Dmitry Antipov
2012-07-24 9:11 ` Stefan Monnier
2012-07-24 11:53 ` Dmitry Antipov
2012-07-24 21:59 ` Stefan Monnier
2012-07-25 9:55 ` Dmitry Antipov [this message]
2012-07-25 23:47 ` Stefan Monnier
2012-07-23 11:10 ` Stephen J. Turnbull
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=500FC2AF.9080300@yandex.ru \
--to=dmantipov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.