From: martin rudalics <rudalics@gmx.at>
To: Roland Winkler <winkler@gnu.org>
Cc: 11985@debbugs.gnu.org
Subject: bug#11985: 24.1; fit-window-to-buffer does not grab whole frame
Date: Thu, 19 Jul 2012 12:42:14 +0200 [thread overview]
Message-ID: <5007E486.7090202@gmx.at> (raw)
In-Reply-To: <87obnc5l09.fsf@gnu.org>
> Start emacs -Q. Visit a file larger than the current frame.
> Split the frame, Display other stuff in second window.
> Select the window with the large file.
> Eval
>
> (fit-window-to-buffer (selected-window))
>
> Expected result: The window should grab the whole frame. From the
> docstring of fit-window-to-buffer
>
> Optional argument MAX-HEIGHT specifies the maximum height of
> WINDOW and defaults to the height of WINDOW's frame.
>
> Remarks:
> (1) This works as documented with GNU Emacs 23.1.
> -- Of course, the old behavior was counterintuitive in the sense
> that the name of fit-window-to-buffer refers to windows, not to
> frames. But an incompatible change in behavior should be
> documented.
From NEWS:
*** Window resizing functions.
A new standard function for resizing windows called `window-resize' has
been introduced. This and all other functions for resizing windows no
longer delete any windows when they become too small.
> (2) I suggest that the elisp manual should also mention the default
> values of MAX-HEIGHT and MIN-HEIGHT (as in the docstring).
OK.
> (3) The relation between the new arg OVERRIDE (not present in Emacs
> 23.1) and window-min-height and window-min-width is not clear to
> me.
Neither to me.
> If MIN-HEIGHT is non-nil, shouldn't this already ignore
> window-min-height?
Sounds reasonable, indeed.
> Also, if OVERRIDE is nil, what is the
> relevance of window-min-width? I expect fit-window-to-buffer is
> supposed to obey window-min-width. But it would clarify things
> if this was spelled out.
`window-min-width' shouldn't be mentioned at all.
I'll look into this. If you have any ideas what this function should
_do_ better, please tell me.
martin
next prev parent reply other threads:[~2012-07-19 10:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-19 6:21 bug#11985: 24.1; fit-window-to-buffer does not grab whole frame Roland Winkler
2012-07-19 10:42 ` martin rudalics [this message]
2012-07-19 16:14 ` martin rudalics
2012-07-19 16:32 ` Roland Winkler
2012-07-21 11:01 ` martin rudalics
2012-07-28 22:59 ` Roland Winkler
2012-10-06 12:56 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5007E486.7090202@gmx.at \
--to=rudalics@gmx.at \
--cc=11985@debbugs.gnu.org \
--cc=winkler@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.