From: Dmitry Antipov <dmantipov@yandex.ru>
To: Andy Moreton <andrewjmoreton@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: Windows build broken on trunk
Date: Wed, 18 Jul 2012 13:55:59 +0400 [thread overview]
Message-ID: <5006882F.2060503@yandex.ru> (raw)
In-Reply-To: <vz1sjcph33u.fsf@gmail.com>
On 07/18/2012 12:42 PM, Andy Moreton wrote:
> Bootstrapping trunk on Windows (mingw32 GCC 4.6.1) failed this morning:
>
> w32font.c:78:40: error: static declaration of 'Qsymbol' follows non-static declaration
> lisp.h:2335:41: note: previous declaration of 'Qsymbol' was here
> mingw32-make[3]: *** [oo/i386/w32font.o] Error 1
> mingw32-make[3]: Leaving directory `C:/emacs/src/emacs/trunk/src'
>
> This appers to be from r109131 committed by Dmitry Antipov.
>
> I'm not familiar with the code: is the static Qsymbol used in w32font.c
> referring to some aspect of font handling, or is it the same thing as the
> global that was added to src/lisp.h ?
IIUC it's font handling stuff, and (IMHO) it should be renamed from too
generic name to something which is closely related to symbol's real use.
Dmitry
next prev parent reply other threads:[~2012-07-18 9:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-18 8:42 Windows build broken on trunk Andy Moreton
2012-07-18 9:55 ` Dmitry Antipov [this message]
2012-07-18 10:10 ` Andreas Schwab
2012-07-18 12:23 ` Andy Moreton
2012-07-18 12:37 ` Andreas Schwab
2012-07-18 13:38 ` Jason Rumney
2012-07-19 7:05 ` Stefan Monnier
2012-07-19 16:22 ` Samuel Bronson
2012-07-19 22:49 ` Stefan Monnier
2012-07-20 7:52 ` Andreas Schwab
2012-07-20 9:30 ` Stephen J. Turnbull
2012-07-20 9:55 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5006882F.2060503@yandex.ru \
--to=dmantipov@yandex.ru \
--cc=andrewjmoreton@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.