From: Dmitry Gutov <dgutov@yandex.ru>
To: fhd@ubercode.de
Cc: 8576@debbugs.gnu.org
Subject: bug#8576: 23.2; js-mode doesn't support multi-line variable declarations
Date: Tue, 17 Jul 2012 08:21:27 +0400 [thread overview]
Message-ID: <5004E847.2070000@yandex.ru> (raw)
In-Reply-To: <4DB915B0.7010605@ubercode.de>
"Felix H. Dahlke" <fhd@ubercode.de> writes:
> I tried some things but couldn't really make it work like I wanted.
> So I decided to just improve the patch a bit. I am now using the
> proper indentation which also fixes the issue reported by jaseemabid.
Yes, that's a bit better than my fix.
You shouldn't add the `js--indent-operator-re' constant, though, it's
already present in js-mode.
> The only solution I can think of would be to go back up after typing a
> closing brace followed by a comma and indent the preceeding lines.
> Some modes do that, but it would require drastic changes to js.el.
> I'd rather get this patch in first and see if the issue annoys me (or
> anyone else) enough to work further on this.
I don't think this will be much of a problem.
There is an alternative approach, though: one js2-mode user requested
that when the first value in the declaration is a function/object/array,
it should always be indented: https://github.com/mooz/js2-mode/issues/3
That option probably won't be very popular.
--Dmitry
next prev parent reply other threads:[~2012-07-17 4:21 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-28 7:22 bug#8576: 23.2; js-mode doesn't support multi-line variable declarations Felix H. Dahlke
2011-06-19 20:38 ` Daniel Colascione
2012-02-15 12:32 ` Felix H. Dahlke
2012-02-15 18:58 ` Stefan Monnier
2012-02-15 19:04 ` Glenn Morris
2012-02-15 19:25 ` Daniel Colascione
2012-02-15 20:41 ` Stefan Monnier
2012-04-04 11:26 ` Felix H. Dahlke
2012-06-01 7:30 ` Felix H. Dahlke
[not found] ` <mailman.2065.1338535901.855.bug-gnu-emacs@gnu.org>
2012-07-05 14:53 ` jaseemabid
2012-02-24 2:16 ` Dmitry Gutov
2012-03-03 1:46 ` bug#8576: " Zeth
2012-03-03 4:51 ` Daniel Colascione
2012-06-07 23:04 ` bug#8576: 23.2; " Dmitry Gutov
2012-06-08 3:13 ` Felix H. Dahlke
2012-07-17 3:16 ` Felix H. Dahlke
2012-07-05 23:02 ` bug#8576: 23.2; , " Dmitry Gutov
2012-07-06 0:52 ` Dmitry Gutov
[not found] ` <mailman.4157.1341536766.855.bug-gnu-emacs@gnu.org>
2012-07-06 1:23 ` jaseemabid
2012-07-17 4:21 ` Dmitry Gutov [this message]
2012-07-17 4:37 ` bug#8576: 23.2; " Felix H. Dahlke
2012-07-17 5:00 ` Dmitry Gutov
2012-07-17 6:32 ` Stefan Monnier
2012-07-17 8:24 ` Felix H. Dahlke
2012-07-17 9:50 ` Stefan Monnier
2012-07-17 9:51 ` Felix H. Dahlke
2012-07-17 17:33 ` Felix H. Dahlke
2013-01-10 3:48 ` Felix H. Dahlke
2013-01-11 23:25 ` Stefan Monnier
2013-01-12 2:59 ` Felix H. Dahlke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5004E847.2070000@yandex.ru \
--to=dgutov@yandex.ru \
--cc=8576@debbugs.gnu.org \
--cc=fhd@ubercode.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.