From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#25359: autoreconf no longer suffices Date: Fri, 06 Jan 2017 13:13:49 -0500 Message-ID: <4ishowoy3m.fsf@fencepost.gnu.org> References: <1wpeawrbj.fsf@fencepost.gnu.org> <83k2aaegux.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1483726459 22824 195.159.176.226 (6 Jan 2017 18:14:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 6 Jan 2017 18:14:19 +0000 (UTC) User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) Cc: 25359@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jan 06 19:14:15 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cPZ1k-0004mj-Db for geb-bug-gnu-emacs@m.gmane.org; Fri, 06 Jan 2017 19:14:08 +0100 Original-Received: from localhost ([::1]:54335 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cPZ1o-0003Lc-Ip for geb-bug-gnu-emacs@m.gmane.org; Fri, 06 Jan 2017 13:14:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54173) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cPZ1f-0003Kk-IN for bug-gnu-emacs@gnu.org; Fri, 06 Jan 2017 13:14:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cPZ1e-0006Kr-J2 for bug-gnu-emacs@gnu.org; Fri, 06 Jan 2017 13:14:03 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:58202) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cPZ1e-0006Kk-Fk for bug-gnu-emacs@gnu.org; Fri, 06 Jan 2017 13:14:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cPZ1e-0002vH-8b for bug-gnu-emacs@gnu.org; Fri, 06 Jan 2017 13:14:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 06 Jan 2017 18:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25359 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25359-submit@debbugs.gnu.org id=B25359.148372643711217 (code B ref 25359); Fri, 06 Jan 2017 18:14:02 +0000 Original-Received: (at 25359) by debbugs.gnu.org; 6 Jan 2017 18:13:57 +0000 Original-Received: from localhost ([127.0.0.1]:45368 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cPZ1Y-0002ur-RE for submit@debbugs.gnu.org; Fri, 06 Jan 2017 13:13:57 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:34948) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cPZ1X-0002ue-Rl for 25359@debbugs.gnu.org; Fri, 06 Jan 2017 13:13:56 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cPZ1R-0006JW-Ry for 25359@debbugs.gnu.org; Fri, 06 Jan 2017 13:13:50 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:34129) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cPZ1R-0006JO-Oo for 25359@debbugs.gnu.org; Fri, 06 Jan 2017 13:13:49 -0500 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1cPZ1R-0007sl-6o; Fri, 06 Jan 2017 13:13:49 -0500 X-Spook: bank Plot SAPO Leuken-Baden red noise Montenegro Metro X-Ran: e.uS|hXmKX-Q_T9rA0%yXgf{]u|)QYB7\HQPy*l"b$w#(IlaP8"4xZ4+D!&yN{GhEI%bYc X-Hue: black X-Attribution: GM In-Reply-To: <83k2aaegux.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 04 Jan 2017 21:59:34 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:127851 Archived-At: Eli Zaretskii wrote: >> I think it is wrong to make autogen.sh compulsory in this way. > > Why do you think it's wrong? Perhaps it's just my opinion. It was the original intent of autogen.sh to be just a convenience wrapper for sanity checks + autoreconf. If this is no longer true, here are some places that need to be changed: 1) autogen.sh error output says: "If you know that the required versions are in your PATH, but this script has made an error, then you can simply run autoreconf -fi -I m4 instead of this script." (INSTALL.REPO used to say this too, before the IMO unrelated a3f989d removed it.) 2) make-dist with update=yes uses autoreconf 3) top-level Makefile needs updating as per bug#25372 4) autogen.sh should ensure the outputs are newer than the inputs. nt/gnulib.mk is only tested for existence, not freshness. Since we use autoreconf -f, I think you can simply unconditionally create nt/gnulib.mk every time. All in all, it would make lifer simpler if plain automake would still work, but I can see it might be difficult to implement. >> (Obviously the missing file is irrelevant anyway on non MS-Windows >> platforms.) > > Evidently, it isn't irrelevant, otherwise the error would have never > happened, right? Eg "touch nt/gnulib.mk" works just as well on non-MS platforms, where the contents of the file are completely irrelevant.