From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#33799: 27.0.50; set-foreground-color completion shows background colors Date: Thu, 20 Dec 2018 12:49:35 -0500 Message-ID: <4i7eg45brk.fsf@fencepost.gnu.org> References: <875zvqz8om.fsf@mail.linkov.net> <5aftutcptc.fsf@fencepost.gnu.org> <87lg4lnvwp.fsf@mail.linkov.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1545328085 5455 195.159.176.226 (20 Dec 2018 17:48:05 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 20 Dec 2018 17:48:05 +0000 (UTC) User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) Cc: 33799@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 20 18:48:01 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ga2QQ-0001DD-Py for geb-bug-gnu-emacs@m.gmane.org; Thu, 20 Dec 2018 18:47:58 +0100 Original-Received: from localhost ([::1]:39110 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ga2SX-0008Ii-Iy for geb-bug-gnu-emacs@m.gmane.org; Thu, 20 Dec 2018 12:50:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45857) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ga2SR-0008IQ-1I for bug-gnu-emacs@gnu.org; Thu, 20 Dec 2018 12:50:03 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ga2SQ-0004eS-Ah for bug-gnu-emacs@gnu.org; Thu, 20 Dec 2018 12:50:02 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52453) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ga2SQ-0004e9-60 for bug-gnu-emacs@gnu.org; Thu, 20 Dec 2018 12:50:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ga2SQ-00009g-24 for bug-gnu-emacs@gnu.org; Thu, 20 Dec 2018 12:50:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Dec 2018 17:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33799 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33799-submit@debbugs.gnu.org id=B33799.1545328185564 (code B ref 33799); Thu, 20 Dec 2018 17:50:02 +0000 Original-Received: (at 33799) by debbugs.gnu.org; 20 Dec 2018 17:49:45 +0000 Original-Received: from localhost ([127.0.0.1]:56711 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ga2S8-000092-Lh for submit@debbugs.gnu.org; Thu, 20 Dec 2018 12:49:44 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:36160) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ga2S7-00008p-AD for 33799@debbugs.gnu.org; Thu, 20 Dec 2018 12:49:43 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ga2S1-00049Z-M0 for 33799@debbugs.gnu.org; Thu, 20 Dec 2018 12:49:38 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41364) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ga2Rz-00047A-BS; Thu, 20 Dec 2018 12:49:35 -0500 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1ga2Rz-0007pQ-4e; Thu, 20 Dec 2018 12:49:35 -0500 X-Spook: Hazardous Torreon Drug Administration Vince Foster X-Ran: 8B(qRv[4_C^^ngYP,A+z|~lV]`$h2beQE4%Ku99b{sfu}km?YSzcj{|@5V%9:~J0Rx28F~ X-Hue: black X-Attribution: GM In-Reply-To: <87lg4lnvwp.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 19 Dec 2018 23:34:54 +0200") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:153644 Archived-At: Juri Linkov wrote: > I don't know if readable background is needed for set-foreground-color > like readable foreground is used for set-background-color. I think > your change to not use readable background is more correct because > then the user will see how the selected color will fit with the background. > This helps to select a suitable combination of foreground/background > colors. The same way maybe readable foreground should be removed > from the completions of set-background-color. This would allow to see > how the current foreground color will look on different backgrounds > in the completion list. I think defined-colors-with-face-attributes probably needs yet another argument, to control whether the non-varying component (be it foreground or background) is a fixed value or a changing "readable" one.