From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED!not-for-mail
From: Glenn Morris <rgm@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: emacs-26 6ddb4bd: Fix 'vc-git--program-version'
Date: Fri, 16 Feb 2018 11:56:05 -0500
Message-ID: <4finawzxei.fsf@fencepost.gnu.org>
References: <20180216093116.572.67356@vcs0.savannah.gnu.org>
	<20180216093117.66FB5206A2@vcs0.savannah.gnu.org>
NNTP-Posting-Host: blaine.gmane.org
Mime-Version: 1.0
Content-Type: text/plain
X-Trace: blaine.gmane.org 1518800229 9385 195.159.176.226 (16 Feb 2018 16:57:09 GMT)
X-Complaints-To: usenet@blaine.gmane.org
NNTP-Posting-Date: Fri, 16 Feb 2018 16:57:09 +0000 (UTC)
User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/)
Cc: Eli Zaretskii <eliz@gnu.org>
To: emacs-devel@gnu.org
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Feb 16 17:57:05 2018
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([208.118.235.17])
	by blaine.gmane.org with esmtp (Exim 4.84_2)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1emjJZ-0001Bn-Ky
	for ged-emacs-devel@m.gmane.org; Fri, 16 Feb 2018 17:56:49 +0100
Original-Received: from localhost ([::1]:40135 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1emjLb-0001jm-J3
	for ged-emacs-devel@m.gmane.org; Fri, 16 Feb 2018 11:58:55 -0500
Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60443)
	by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <rgm@gnu.org>)
	id 1emjIv-0007gm-Im
	for emacs-devel@gnu.org; Fri, 16 Feb 2018 11:56:10 -0500
Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rgm@gnu.org>) id 1emjIu-0004Cd-Bb
	for emacs-devel@gnu.org; Fri, 16 Feb 2018 11:56:09 -0500
Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:38004)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <rgm@gnu.org>)
	id 1emjIu-0004CR-7q
	for emacs-devel@gnu.org; Fri, 16 Feb 2018 11:56:08 -0500
Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.82)
	(envelope-from <rgm@gnu.org>)
	id 1emjIr-0008JU-Re; Fri, 16 Feb 2018 11:56:05 -0500
X-Spook: Maritime domain awarenes supercomputer SAPO Stuck anarchy
X-Ran: 2e_X,|s)+f,5Up4$Q3l&<)`RcO@RmK0*;\utgwm/*+gG6F70G9/n$jY[lKDoT=~h{&0V.f
X-Hue: black
X-Attribution: GM
In-Reply-To: <20180216093117.66FB5206A2@vcs0.savannah.gnu.org> (Eli
	Zaretskii's message of "Fri, 16 Feb 2018 04:31:17 -0500 (EST)")
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 2001:4830:134:3::e
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel/>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:222830
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/222830>

Eli Zaretskii wrote:

> commit 6ddb4bd39ac0629e4e06221a41120aee7c18f548

>     * lisp/vc/vc-git.el (vc-git--program-version): Fix the function to
>     work with Git for Windows.
> -                       (string-match "git version \\([0-9.]+\\)$"
> -                                     version-string))
> +                       ;; Git for Windows appends ".windows.N" to the
> +                       ;; numerical version reported by Git.
> +                       (string-match
> +                        "git version \\([0-9.]+\\)\\(\.windows.[0-9]+\\)$"
> +                        version-string))

Surely this breaks on all non-MS Windows platforms?