From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Fu Yuan Newsgroups: gmane.emacs.bugs Subject: bug#31324: 26.0.91; Wrong AXSubrole of childframe on macOS Date: Sun, 13 May 2018 18:17:10 +0800 Message-ID: <4f6f4596-948e-471c-bb2b-aa8c8abead99@Spark> References: <58a8e0b4-311c-4aa4-a5f1-f968ca93b6d3@Spark> <20180501203758.GA74662@breton.holly.idiocy.org> <034b13c0-b1c0-4340-bfd5-3de34f60322f@Spark> <20180513101402.GB15823@breton.holly.idiocy.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="5af81184_2ae8944a_99a5" X-Trace: blaine.gmane.org 1526250851 6686 195.159.176.226 (13 May 2018 22:34:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 13 May 2018 22:34:11 +0000 (UTC) Cc: 31324@debbugs.gnu.org To: Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon May 14 00:34:06 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fHzZ8-0001de-EV for geb-bug-gnu-emacs@m.gmane.org; Mon, 14 May 2018 00:34:06 +0200 Original-Received: from localhost ([::1]:60785 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fHzbF-0006mz-MF for geb-bug-gnu-emacs@m.gmane.org; Sun, 13 May 2018 18:36:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52070) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fHzb2-0003Qm-NA for bug-gnu-emacs@gnu.org; Sun, 13 May 2018 18:36:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fHyxK-0008Az-MS for bug-gnu-emacs@gnu.org; Sun, 13 May 2018 17:55:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53163) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fHyxK-0008As-Gg for bug-gnu-emacs@gnu.org; Sun, 13 May 2018 17:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fHyxK-0007Nt-5W for bug-gnu-emacs@gnu.org; Sun, 13 May 2018 17:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Fu Yuan Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 May 2018 21:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31324 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31324-submit@debbugs.gnu.org id=B31324.152624849128366 (code B ref 31324); Sun, 13 May 2018 21:55:02 +0000 Original-Received: (at 31324) by debbugs.gnu.org; 13 May 2018 21:54:51 +0000 Original-Received: from localhost ([127.0.0.1]:32827 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fHyx8-0007NR-8o for submit@debbugs.gnu.org; Sun, 13 May 2018 17:54:51 -0400 Original-Received: from mail-qt0-f176.google.com ([209.85.216.176]:39245) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fHo7o-0000Xy-Ri for 31324@debbugs.gnu.org; Sun, 13 May 2018 06:21:09 -0400 Original-Received: by mail-qt0-f176.google.com with SMTP id f1-v6so12652234qtj.6 for <31324@debbugs.gnu.org>; Sun, 13 May 2018 03:21:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:message-id:in-reply-to:references:subject :mime-version; bh=iiYlo28yijcvsNaCVZisw6Tv5b4z69HqJN5waJUBOGU=; b=VoGdHafxnXcnj+QgVMryjmxEtK44RrbHeDsja010k6hdU2abu0MYAQI3tkzJgrD2Bg W2g39tRJdIBt662WRRutGII46WIqdHB5RhR3cakzIEmBub+Nn6f7UcbySz1nmxgZJy2+ ZLRwjgT2H8udcThTpBtZFRiGgFwpgxKomzgsat5IBWWLtSkuk/BuP8Sc9eP1yHqPUVNQ 0HYL7v/p1D5QX3RqNOgzDT7KbQ2qm6d+AUJ1p6KxqZoZDA0KkDAv5DbBsMxdB9onpx/9 SyEfw7GyCYy0xXd9M+Pp0P9chLE7PVWajdQKrHKnmvgLRCuhu/1CX45Pe2JBwIHYLTO3 DWWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:message-id:in-reply-to :references:subject:mime-version; bh=iiYlo28yijcvsNaCVZisw6Tv5b4z69HqJN5waJUBOGU=; b=hmcCGy89/7GpsK4DXzPijWpaa1pjyieeaq6KVYNeUSJ5N4HjX5TDY8Gf2euE3PQp94 HYuqvYeBWy7ntniereh2X+rZcnsofjJJCqlk9MRAc/OEv98imHAKoiA/WwvDJTp+e+Tb DjCQhY9apLDMH4X126C1aVVupKCBZFNz6MzkHkAOVC690XglyPHpm3JllZqb5GIpk+lg wdaFLtDHJVCMI4zNsGzspccOxJ2I0+j0CgvIKtsP975kkk2d0wrYt+vDdwstjE+y+bfW jrPX5x1wPwuXloJOJJ0RJRiwKn7lZ8DZRZaPhCgL65zQTJcf/GIPN6JBOKVpUk5R7lZY FjFA== X-Gm-Message-State: ALKqPweVFAScIOMvIqeLK5smX4ij2LbI/F0Zw9tdKlwBRBnPa3m49efd 7vVK1bueIWp5vqJynIV/PJ4= X-Google-Smtp-Source: AB8JxZqu9BQlzd6JkIIC7F/MicHEn7UsW2KmiN147NpvL6Lofa5MB3IMmNqTjgU51Sq7FaYb1wMmBQ== X-Received: by 2002:a0c:b59b:: with SMTP id g27-v6mr5026627qve.126.1526206863162; Sun, 13 May 2018 03:21:03 -0700 (PDT) Original-Received: from [127.0.0.1] (164.ip-144-217-84.net. [144.217.84.164]) by smtp.gmail.com with ESMTPSA id l5-v6sm5299373qtp.25.2018.05.13.03.21.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 13 May 2018 03:21:02 -0700 (PDT) In-Reply-To: <20180513101402.GB15823@breton.holly.idiocy.org> X-Readdle-Message-ID: 4f6f4596-948e-471c-bb2b-aa8c8abead99@Spark X-Mailman-Approved-At: Sun, 13 May 2018 17:54:49 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:146157 Archived-At: --5af81184_2ae8944a_99a5 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Hi Alan, Where should I get the Emacs source files=3F I was getting those from emacs mirror on GitHub master branch. Last time I manually edited your fix and noticed that line numbers doesn=E2= =80=99t match. So I guess you are not using HEAD version to create those patches. What version or commit or branch should I use=3F Thanks. Sincerely, Yuan. On May 13, 2018, 6:14 PM +0800, Alan Third , wrote: > Please keep the bug tracker Cc=E2=80=99d in. > > On =46ri, May 11, 2018 at 09:31:14PM +0800, =46u Yuan wrote: > > I first ran the lisp code and nothing changed. Then I patched source > > file and compiled, then ran the lisp code on the compiled emacs. > > Nothing different on that Emacs. The UIElementInspecter shows > > AXStandardWindow. Of course both time I used =E2=80=9Cemacs=22 comman= d with > > =E2=80=9C-Q=22 flag. > > > > Is there anything else I can do=3F > > OK, I looked into this a bit further and it seems this stuff is in the > accessibility API. I=E2=80=99ve attached a couple of patches, please ap= ply > =E2=80=98fix redefinition of child frames on NS=E2=80=99, then =E2=80=98= Set accessibility > subroles for child frame=E2=80=99 and see if it does what you expect. > > This will only work on macOS >=3D 10.10. I think there must be another > way of doing it on older versions but I haven=E2=80=99t found it yet. I= =E2=80=99ll see > if this works before digging any more. > -- > Alan Third --5af81184_2ae8944a_99a5 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline
Hi Alan,

Where should I get the Emacs source files=3F
I was getting those from emacs mirror on GitHub master branch.
=
Last time I manually edited your fix and noticed that line numbers d= oesn=E2=80=99t match.
So I guess you are not using HEAD version to create those patches.

What version or commit or branch should I use=3F
Thanks.

Sincerely, Yuan.

On May 13, 2018, 6:14 PM +0800, Alan Third <alan=40idiocy.org>, wro= te:
Please keep the bug tracker Cc= =E2=80=99d in.

On =46ri, May 11, 2018 at 09:31:14PM +0800, =46u Yuan wrote:
I first ran the lisp code and = nothing changed. Then I patched source
file and compiled, then ran the lisp code on the compiled emacs.
Nothing different on that Emacs. The UIElementInspecter shows
AXStandardWindow. Of course both time I used =E2=80=9Cemacs=22 command wi= th
=E2=80=9C-Q=22 flag.

Is there anything else I can do=3F

OK, I looked into this a bit further and it seems this stuff is in the accessibility API. I=E2=80=99ve attached a couple of patches, please appl= y
=E2=80=98fix redefinition of child frames on NS=E2=80=99, then =E2=80=98S= et accessibility
subroles for child frame=E2=80=99 and see if it does what you expect.

This will only work on macOS >=3D 10.10. I think there must be another=
way of doing it on older versions but I haven=E2=80=99t found it yet. I=E2= =80=99ll see
if this works before digging any more.
--
Alan Third
--5af81184_2ae8944a_99a5--