From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#59103: 29.0.50; esh-var-tests intermittently fails on macOS 12.6.1 Date: Mon, 7 Nov 2022 21:39:57 -0800 Message-ID: <4f0dad10-9664-ce87-6525-0389363b883f@gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23134"; mail-complaints-to="usenet@ciao.gmane.io" To: Stefan Kangas , 59103@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 08 06:41:12 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1osHMG-0005oy-Rt for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Nov 2022 06:41:12 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1osHM8-0003p8-Jz; Tue, 08 Nov 2022 00:41:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1osHM6-0003p0-J8 for bug-gnu-emacs@gnu.org; Tue, 08 Nov 2022 00:41:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1osHM6-0004aY-8N for bug-gnu-emacs@gnu.org; Tue, 08 Nov 2022 00:41:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1osHM5-0004bR-U9 for bug-gnu-emacs@gnu.org; Tue, 08 Nov 2022 00:41:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Nov 2022 05:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59103 X-GNU-PR-Package: emacs Original-Received: via spool by 59103-submit@debbugs.gnu.org id=B59103.166788600817617 (code B ref 59103); Tue, 08 Nov 2022 05:41:01 +0000 Original-Received: (at 59103) by debbugs.gnu.org; 8 Nov 2022 05:40:08 +0000 Original-Received: from localhost ([127.0.0.1]:35997 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1osHLD-0004a3-Tb for submit@debbugs.gnu.org; Tue, 08 Nov 2022 00:40:08 -0500 Original-Received: from mail-pj1-f47.google.com ([209.85.216.47]:40623) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1osHLB-0004ZR-VE for 59103@debbugs.gnu.org; Tue, 08 Nov 2022 00:40:06 -0500 Original-Received: by mail-pj1-f47.google.com with SMTP id r61-20020a17090a43c300b00212f4e9cccdso16893691pjg.5 for <59103@debbugs.gnu.org>; Mon, 07 Nov 2022 21:40:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=z65tOBvgGp1LGGXEdq0xbv1qCn7Xz24v3mVNob01F7g=; b=RMSiR7hHBy9vs90JISgHPZgLfjVzSywCqG4ggo29nys74emD3y78p1tFs6XbF0K8o7 1RnkAVRX5SoJBjJhGEpfw8PdTboc78GznHllGh/BGNwb+gd/Awk211PBEcN0fBx5HT2i YDRAUszYbdrq/diN8+bpKHNzWCqakTECNAZe0FPIzVrnerOOEEh3dZwSxJD0ZT/5IBJ4 oyR0wd+HFc2jOOuDqD97GjoFKbS596nFOMNpoHyD+yjzwoEZvkUN0VAPeo5AK0lY+oBw fPMGEDvGPb37wLCTiVKYTBOJEtDWXOud8l3oO69VLmct73uTqeElQLeB7MU4drLp/+k6 kirA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=z65tOBvgGp1LGGXEdq0xbv1qCn7Xz24v3mVNob01F7g=; b=U4MVBe7EQnYFM1ajX1IefAeF4nWFnAiTmROaqRvM650vg2OdpfWRNSA16AyYravVCZ +j8a5KpH3JZpANnh9380jC7viYoXbV5O89mSI0Tl7xOgAqskZys5uiXpXk4JxFUAecG7 ognVoH45ZdXJEK/ugrDG7p/yYtwPawbcCKGYfT9mXARuQQTjLBextIqLyxxejV2yKR1E UPSXctdTPTnb4g+EJ+RMfFs09UWAvP7zJzLvR2h4T3h2uIXntEBurFPBXou/gF7bIAGY wMLIlL4vIsThofY+Cw2uqROAOeRjJToR424debZgD7lo84B/uC5pbQ6lzidu4DO787xu j9nQ== X-Gm-Message-State: ACrzQf1egYqEpjk5BQ9pe3Vl15dmYVem1ApcZXzsLicWyKspoaiaS568 7H2u7pAdMyFhvg4pcqZH8j4= X-Google-Smtp-Source: AMsMyM765qYHo9qZtQoH/vrT9XLgy025Yw0yExkErL8c97JFuqi177GElY8wtckLGAqjro+iduem+A== X-Received: by 2002:a17:903:110f:b0:178:a07e:e643 with SMTP id n15-20020a170903110f00b00178a07ee643mr52872403plh.41.1667885999152; Mon, 07 Nov 2022 21:39:59 -0800 (PST) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id z11-20020aa79e4b000000b0056e8eb09d57sm5456449pfq.63.2022.11.07.21.39.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Nov 2022 21:39:58 -0800 (PST) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:247316 Archived-At: On 11/7/2022 3:09 AM, Stefan Kangas wrote: > Intermittently failing test on macOS 12.6.1, see below output from > "make -j5 check": > [snip] > They do not fail every time: sometimes neither fails, sometimes one > does and sometimes the other. Only once did both fail at the same > time, after several runs of "make check". Both of these failures look like the ${subcommand} didn't see any output by the time Eshell expanded it into the top-level command. My guess is that something is going awry in 'eshell-sentinel'. I haven't been able to reproduce this locally (on a GNU/Linux system), but since it seems you *can* reproduce it, you could try the following: 1. Check if 'eshell-output-object' ever gets called from within 'eshell-sentinel' or from the 'finish-io' timer defined there 2. If so, try moving the 'eshell-kill-process-function' call at the end of 'eshell-sentinel' (and maybe the 'when-let' block immediately above it) inside 'finish-io' My reasoning here is that I think 'eshell-kill-process-function' is what will signal to the rest of Eshell that the process is done, but if the process still has output pending (i.e. 'finish-io' gets called from a timer to do its thing), then that pending output would get lost. Hopefully that at least points you in the right direction...