From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Brennan Vincent Newsgroups: gmane.emacs.bugs Subject: bug#56430: [PATCH] fix broken `imenu--create-keymap` when an item is nil Date: Thu, 7 Jul 2022 10:26:37 -0400 Message-ID: <4efdcf03-a006-fc5a-e724-c2eddeb3cd68@umanwizard.com> References: <87mtdlguwi.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37946"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Cc: 56430@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 07 17:02:34 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o9T1V-0009dx-Np for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 07 Jul 2022 17:02:33 +0200 Original-Received: from localhost ([::1]:37566 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o9T1U-0007rz-O7 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 07 Jul 2022 11:02:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51440) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9T11-0007FU-Ga for bug-gnu-emacs@gnu.org; Thu, 07 Jul 2022 11:02:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35462) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o9T11-0001zU-7M for bug-gnu-emacs@gnu.org; Thu, 07 Jul 2022 11:02:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o9T11-0005kM-4w for bug-gnu-emacs@gnu.org; Thu, 07 Jul 2022 11:02:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Brennan Vincent Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Jul 2022 15:02:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56430 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo patch Original-Received: via spool by 56430-submit@debbugs.gnu.org id=B56430.165720610322041 (code B ref 56430); Thu, 07 Jul 2022 15:02:03 +0000 Original-Received: (at 56430) by debbugs.gnu.org; 7 Jul 2022 15:01:43 +0000 Original-Received: from localhost ([127.0.0.1]:57588 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9T0e-0005jM-6H for submit@debbugs.gnu.org; Thu, 07 Jul 2022 11:01:43 -0400 Original-Received: from smtp.umanwizard.com ([54.203.248.109]:20123) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9SSw-0004kw-QN for 56430@debbugs.gnu.org; Thu, 07 Jul 2022 10:27:00 -0400 X-Fes-Received-For: 56430@debbugs.gnu.org X-Fes-Received-From: brennan@umanwizard.com Original-Received: From [192.168.1.173] ([71.190.149.125]) By umanwizard.com ; 7 Jul 2022 14:26:39+0000 Content-Language: en-US In-Reply-To: <87mtdlguwi.fsf@gnus.org> X-Fes-Encrypted: true X-Fes-Ehlo-Domain: [192.168.1.173] X-Mailman-Approved-At: Thu, 07 Jul 2022 11:01:39 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:236380 Archived-At: I actually observed item itself being nil, not just (car item). It happens in imenu-update-menubar, because imenu--make-index-alist always produces (list nil) instead of just nil. The code is uncommented, so I don't know the original reason for that logic, which you can see here: https://git.savannah.gnu.org/cgit/emacs.git/tree/lisp/imenu.el#n434 This was working fine until imenu--create-keymap was updated to call intern, by your change on June 24th. The practical consequence I observed was that lsp-mode stopped working for Go. On 7/7/22 04:59, Lars Ingebrigtsen wrote: > Content preview: Brennan Vincent writes: > - `(,(intern > (car item)) ,(car item) > + `(,(and (car item) (intern (car item))) ,(car > item) > ,@(cond > ((imenu--subalist-p item) > (imenu--create-keymap (car > item) (cdr item) cmd)) > > Content analysis details: (-2.9 points, 5.0 required) > > pts rule name description > ---- ---------------------- -------------------------------------------------- > -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP > -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% > [score: 0.0000] > X-Fes-Encrypted: true > X-Fes-Ehlo-Domain: quimby.gnus.org > > Brennan Vincent writes: > >> - `(,(intern (car item)) ,(car item) >> + `(,(and (car item) (intern (car item))) ,(car item) >> ,@(cond >> ((imenu--subalist-p item) >> (imenu--create-keymap (car item) (cdr item) cmd)) > > In what cases is (car item) nil here? Isn't that a bug in the caller? > > --