Re: 23.0.50 compile problem on Windows XP

["David Robinow" <drobinow@gmail.com>]

On 10/4/07, Jason Rumney <jasonr@gnu.org> wrote:
> Sridhar Boovaraghavan wrote:
> > Thank you for looking into and diagnosing the problem. I have moved
> > the inclusion of <math.h> above "lisp.h" in the affected files and
> > here's a patch against HEAD that solves this issue.
> >
> There are several other files that include stdlib.h after lisp.h
> conditional on WINDOWSNT too. Does that not also cause the same problem?
> Also msdos.c includes lisp.h before stdlib.h, so there could be a
> problem there too.
>
> I think it is better to remove this definition from lisp.h and include
> stdlib.h in the files that need it. But perhaps there is a good reason
> not to do that in the first place, so I'll wait and let others comment
> on my mail from yesterday before making that change.
 I agree with Jason. Take 'abs' out of lisp.h
 I used to wonder why "abs" wasn't defined in math.h, since it seems
an obvious place to put it. Apparently somebody at Microsoft was
thinking the same thing. Bad idea.

 Anyway, a good rule is: don't use "abs".   It's not that complicated
an algorithm.