From: Paul Eggert <eggert@cs.ucla.edu>
To: Alex Gramiak <agrambot@gmail.com>, Lars Ingebrigtsen <larsi@gnus.org>
Cc: emacs-diffs@gnu.org, emacs-devel@gnu.org
Subject: Re: master updated (05b7953 -> b2b1ccb)
Date: Mon, 20 May 2019 13:34:49 -0700 [thread overview]
Message-ID: <4e8d910b-4c9c-c435-a317-656bd308e5f8@cs.ucla.edu> (raw)
In-Reply-To: <87r28tufo4.fsf@gmail.com>
On 5/20/19 11:47 AM, Alex Gramiak wrote:
> Hmm, this is weird: the warnings seem to be legitimate
> (get_per_char_metric can return NULL)
No, the warnings are not legitimate. Those calls to get_per_char_metric
occur only when get_char_glyph_code succeeds, and when that happens
get_per_char_metric cannot fail.
I wouldn't worry about bogus warnings issued by older instances of GCC,
or issued by GCC with non-default build options. There are too many such
warnings, and we'd waste time (and clutter up the code, perhaps
incorrectly) pacifying them. Just worry about the latest GCC with
default build options.
prev parent reply other threads:[~2019-05-20 20:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190520020459.10030.99221@vcs0.savannah.gnu.org>
[not found] ` <m3ftp972fh.fsf@gnus.org>
2019-05-20 18:47 ` master updated (05b7953 -> b2b1ccb) Alex Gramiak
2019-05-20 18:50 ` Lars Ingebrigtsen
2019-05-20 18:54 ` Alex Gramiak
2019-05-20 20:34 ` Paul Eggert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e8d910b-4c9c-c435-a317-656bd308e5f8@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=agrambot@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=emacs-diffs@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.