From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Daniel Colascione" Newsgroups: gmane.emacs.devel Subject: Re: RFC: [PATCH] isearch enhancements: symbol mode; syntactic filtering Date: Thu, 7 Jul 2011 14:39:09 -0700 Message-ID: <4e162785.e231440a.770d.ffff9d6c@mx.google.com> References: Reply-To: Daniel Colascione NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=Alternative__boundary__1310074755810 X-Trace: dough.gmane.org 1310075043 15908 80.91.229.12 (7 Jul 2011 21:44:03 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 7 Jul 2011 21:44:03 +0000 (UTC) Cc: "emacs-devel@gnu.org" To: "Stefan Monnier" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jul 07 23:43:59 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QewMX-0003lF-HY for ged-emacs-devel@m.gmane.org; Thu, 07 Jul 2011 23:43:57 +0200 Original-Received: from localhost ([::1]:53303 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QewMW-0004q6-Eo for ged-emacs-devel@m.gmane.org; Thu, 07 Jul 2011 17:43:56 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:40053) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QewI6-0003iS-5T for emacs-devel@gnu.org; Thu, 07 Jul 2011 17:39:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QewI4-00081s-Cb for emacs-devel@gnu.org; Thu, 07 Jul 2011 17:39:21 -0400 Original-Received: from mail-pz0-f41.google.com ([209.85.210.41]:42611) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QewI3-00081b-V6 for emacs-devel@gnu.org; Thu, 07 Jul 2011 17:39:20 -0400 Original-Received: by pzk4 with SMTP id 4so1322959pzk.0 for ; Thu, 07 Jul 2011 14:39:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:to:cc:reply-to:subject:in-reply-to:x-mailer :mime-version:content-type; bh=+a/7t4prSclX1RMqnL1GPGkalakBbPtqexjnCRcV7EE=; b=RZdmI9p7mQc5reVXNrEsekDFASpJhgZmdJS9vgmfHn2wamTVtvDmkzRBHvBtWKegKs jgt4eXNISDFxJf6Je3qTjGFSmq6kT+eMWdV8y9AMd69lyT9zK+VZZ9VEP3S3owZn1uTX ucaclibjRvOJtSdXWdqLbsSoCI0EJqOgaH2yo= Original-Received: by 10.68.46.201 with SMTP id x9mr540761pbm.132.1310074758088; Thu, 07 Jul 2011 14:39:18 -0700 (PDT) Original-Received: from www.palm.com ([107.61.81.216]) by mx.google.com with ESMTPS id x2sm5817575pbn.93.2011.07.07.14.39.15 (version=SSLv3 cipher=OTHER); Thu, 07 Jul 2011 14:39:17 -0700 (PDT) In-Reply-To: X-Mailer: Palm webOS v1.0.1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 209.85.210.41 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:141756 Archived-At: --Alternative__boundary__1310074755810 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable I don't have plans to merge this work before the feature freeze ends. I sho= uld have made that clear. As for the behavior --- I strongly dislike it. It can lead to the same sear= ch string being interpreted two different ways. Sent from my Palm Pre On Jul 7, 2011 1:51 PM, Stefan Monnier <monnier@iro.umontreal.ca> wro= te:=20 We're in feature freeze, so it's not a good time to integrate such changes. I haven't had time to look at them, but have one comment below: > Bugfixes > -------- > - After an isearch settings change, we refresh the state stored at the= to of > the stack. This way, we don't lose track of settings after adding char= acters > to the search string and removing them again. IIUC that's not a bug, it's a feature. When I switch to regexp search after starting a normal search, I don't want to revert to non-regexp search just because I noticed that there was a typo and used backspace a few times to go fixing that typo. Stefan --Alternative__boundary__1310074755810 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable I don't have plans to merge this work before the feature freeze ends. I sho= uld have made that clear.

As for the behavior --- I strongly dislike= it. It can lead to the same search string being interpreted two different= ways.


=
Sent from my Palm Pre

On Jul 7, 2011 1:51 PM, Stefan Monnier= <monnier@iro.umontreal.ca> wrote:

We're in feature freeze,= so it's not a good time to integrate
such changes. I haven't had time to look at them, but have one comment
below:

> Bugfixes
> --------
> - After an isearch settings change, we refresh the state stored at= the to of
> the stack. This way, we don't lose track of settings after adding= characters
> to the search string and removing them again.

IIUC that's not a bug, it's a feature. When I switch to regexp search
after starting a normal search, I don't want to revert to non-regexp
search just because I noticed that there was a typo and used backspace
a few times to go fixing that typo.


Stefan
--Alternative__boundary__1310074755810--