Re: master d94ab49: Fix bootstrap after recent undo-redo change

Re: master d94ab49: Fix bootstrap after recent undo-redo change

[Dmitry Gutov]

On 30.09.2021 07:59, Lars Ingebrigtsen wrote:
> -(define-key global-map (kbd "C-?") 'undo-redo)
> +(define-key global-map "\C-?" 'undo-redo)

Sorry about the breakage.

But "\C-?" and (kbd "C-?") are not the same: the former evaluates to a 
string containing the DEL char.

The latter returns something like [67108927], and that's how we avoided 
trying to bind 'undo-redo' to Backspace. This binding only works in GUI 
Emacs, of course.

Re: master d94ab49: Fix bootstrap after recent undo-redo change

[Andreas Schwab]

On Sep 30 2021, Dmitry Gutov wrote:

> On 30.09.2021 07:59, Lars Ingebrigtsen wrote:
>> -(define-key global-map (kbd "C-?") 'undo-redo)
>> +(define-key global-map "\C-?" 'undo-redo)
>
> Sorry about the breakage.
>
> But "\C-?" and (kbd "C-?") are not the same: the former evaluates to a
> string containing the DEL char.
>
> The latter returns something like [67108927],

You can use [(control ??)] for that.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

Re: master d94ab49: Fix bootstrap after recent undo-redo change

[dick]

DG> But "\C-?" and (kbd "C-?") are not the same

My bad, I will always bungle the keymap incantation, just as with regex.

Someone with the necessary server-side privileges ought to spend a weekend
writing a pipeline that:

1. procmail detects patches
2. git am's them to tip of master
3. runs it in emba, and
4. mails the build result back to the patch author

Or, I dunno, we could make another "NonGNU" exception and requisition a
non-free software vendor to handle this for us.  Ruthless efficiency is
something capitalism excels at.

Re: master d94ab49: Fix bootstrap after recent undo-redo change

[Eli Zaretskii]

> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Thu, 30 Sep 2021 14:04:28 +0300
> 
> On 30.09.2021 07:59, Lars Ingebrigtsen wrote:
> > -(define-key global-map (kbd "C-?") 'undo-redo)
> > +(define-key global-map "\C-?" 'undo-redo)
> 
> Sorry about the breakage.
> 
> But "\C-?" and (kbd "C-?") are not the same: the former evaluates to a 
> string containing the DEL char.
> 
> The latter returns something like [67108927], and that's how we avoided 
> trying to bind 'undo-redo' to Backspace. This binding only works in GUI 
> Emacs, of course.

Right.  I tried to fix this, please test.

Re: master d94ab49: Fix bootstrap after recent undo-redo change

[Dmitry Gutov]

On 30.09.2021 14:41, Eli Zaretskii wrote:
>> From: Dmitry Gutov<dgutov@yandex.ru>
>> Date: Thu, 30 Sep 2021 14:04:28 +0300
>>
>> On 30.09.2021 07:59, Lars Ingebrigtsen wrote:
>>> -(define-key global-map (kbd "C-?") 'undo-redo)
>>> +(define-key global-map "\C-?" 'undo-redo)
>> Sorry about the breakage.
>>
>> But "\C-?" and (kbd "C-?") are not the same: the former evaluates to a
>> string containing the DEL char.
>>
>> The latter returns something like [67108927], and that's how we avoided
>> trying to bind 'undo-redo' to Backspace. This binding only works in GUI
>> Emacs, of course.
> Right.  I tried to fix this, please test.

Thanks! It's working now.