From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#25737: 25.1.91; vc-git-log-{incoming,outgoing} fixes Date: Mon, 20 Feb 2017 03:53:24 +0200 Message-ID: <4da6d3e1-a57d-dad9-55db-e4549cf0d280@yandex.ru> References: <87tw7vy6hf.fsf@tromey.com> <87poihxy75.fsf@tromey.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1487555657 32472 195.159.176.226 (20 Feb 2017 01:54:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 20 Feb 2017 01:54:17 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 Cc: 25737@debbugs.gnu.org To: Tom Tromey Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Feb 20 02:54:11 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cfdB2-0007lx-0W for geb-bug-gnu-emacs@m.gmane.org; Mon, 20 Feb 2017 02:54:08 +0100 Original-Received: from localhost ([::1]:35693 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cfdB7-0005Gu-Jv for geb-bug-gnu-emacs@m.gmane.org; Sun, 19 Feb 2017 20:54:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52301) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cfdAz-0005Ge-EM for bug-gnu-emacs@gnu.org; Sun, 19 Feb 2017 20:54:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cfdAw-0005yI-C5 for bug-gnu-emacs@gnu.org; Sun, 19 Feb 2017 20:54:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48490) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cfdAw-0005y1-8H for bug-gnu-emacs@gnu.org; Sun, 19 Feb 2017 20:54:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cfdAv-0008ID-Pc for bug-gnu-emacs@gnu.org; Sun, 19 Feb 2017 20:54:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 20 Feb 2017 01:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25737 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 25737-submit@debbugs.gnu.org id=B25737.148755561331839 (code B ref 25737); Mon, 20 Feb 2017 01:54:01 +0000 Original-Received: (at 25737) by debbugs.gnu.org; 20 Feb 2017 01:53:33 +0000 Original-Received: from localhost ([127.0.0.1]:46689 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cfdAT-0008HT-E0 for submit@debbugs.gnu.org; Sun, 19 Feb 2017 20:53:33 -0500 Original-Received: from mail-wr0-f176.google.com ([209.85.128.176]:36826) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cfdAS-0008HG-4k for 25737@debbugs.gnu.org; Sun, 19 Feb 2017 20:53:32 -0500 Original-Received: by mail-wr0-f176.google.com with SMTP id 89so51385329wrr.3 for <25737@debbugs.gnu.org>; Sun, 19 Feb 2017 17:53:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=CLbNC+CUSMJDoIsYWaTFQZZg1UjapeKx0K88PuXQYzE=; b=JsNIAVoFH0VtQG8zheXVqo7g6iabZU6T4egyDEVqGeUEnabjuZZU5dSs4hUYIW680f h136LcWSajvSY1CYpjtCXknhBOJf1B46Rf7D9b2Qki2skOa6eZHBz9dlEo5CEnUeVi93 LgRl1ZaGDE+HXV/L2svcDUjiZ2VvDppMJ63eozy9k2HHjfsibi+JPPRxPyLzzpkkMzD0 G3u5DECeIKKLP+9vY+KLIqIBSdGj9yZePaijXgyOiCpAq2/tL6tDeXIVWJgvvAkjJQCv pg89sCWvQeAVUWQxBJFIFPFisGHAOwPkqdJYzGUqA+KVEQb+QUYq0cuf+m1wDBYpxIhd I2Mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=CLbNC+CUSMJDoIsYWaTFQZZg1UjapeKx0K88PuXQYzE=; b=RA8wP9cBYvHLdiySjUudgpNqqljJRZQbbzi79QFX+nQkcCZMYun9ySBIAyr7PruLLv K/9NZIJORwFL426IJH6pfuBsUEgr8m6ZjcJrTK0CBhM5Jg6d35Yngl5RLFlpGr6EknKV 01UzBfvOsMPGzJuGqecOEfdUcEdP0cwKfqjtaY2gqwai+DP1vbZVUWceIX9sLzsq7/AX kIynLve4Vrzlx2F8En0H8zuaUMRdhIlPuyk03KI8Xa6NQjl7cAdImLmitTKvAmmH3Fw8 kMl6g5R8yYllcwfpZzYZRM2FhaYLtFPnS5KVbstgl2NVxOvWky/zthHRNLCDNK/6LeGv THvQ== X-Gm-Message-State: AMke39mvkR44pAWRTWIoM03H0TLV1sXKreHnU2PVGsfPcsMQEfCWH/VoOcENR6BGXh3MVw== X-Received: by 10.223.167.66 with SMTP id e2mr13378776wrd.48.1487555606399; Sun, 19 Feb 2017 17:53:26 -0800 (PST) Original-Received: from [192.168.1.3] ([185.105.173.41]) by smtp.googlemail.com with ESMTPSA id q16sm22659109wra.69.2017.02.19.17.53.25 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Sun, 19 Feb 2017 17:53:25 -0800 (PST) In-Reply-To: <87poihxy75.fsf@tromey.com> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:129560 Archived-At: On 17.02.2017 06:01, Tom Tromey wrote: > Dmitry> Do you know when they get called with ""? > > vc-log-outgoing does: > > (interactive > (when current-prefix-arg > (list (read-string "Remote location (empty for default): ")))) > > So a prefix argument followed by pressing enter. > > Dmitry> Should we maybe just change the callers to always use one or the other > Dmitry> value? > > Seems reasonable, I'll change vc-log-outgoing. Thanks. > As you say, point ends up at eob due to vc-do-command using process-file > in the synchronous case; whereas for the async case, vc-process-filter > uses save-excursion. Yes, and it's a problem we need to fix either way. > The other behavior seems to be a problem in > shrink-window-if-larger-than-buffer. I can reproduce it easily just > with any buffer by moving point to the end. I didn't debug this any > further than finding that. Might want to look into that sometime. I've tried that in different configurations, and 'M-x shrink-window-if-larger-than-buffer' doesn't do anything if the buffer is longer than the current window height. If it's shorter, the window gets shrunk appropriately, with only the off-by-one scrolling problem.