From: Dmitry Gutov <dgutov@yandex.ru>
To: Tom Tromey <tom@tromey.com>
Cc: 25737@debbugs.gnu.org
Subject: bug#25737: 25.1.91; vc-git-log-{incoming,outgoing} fixes
Date: Mon, 20 Feb 2017 03:53:24 +0200 [thread overview]
Message-ID: <4da6d3e1-a57d-dad9-55db-e4549cf0d280@yandex.ru> (raw)
In-Reply-To: <87poihxy75.fsf@tromey.com>
On 17.02.2017 06:01, Tom Tromey wrote:
> Dmitry> Do you know when they get called with ""?
>
> vc-log-outgoing does:
>
> (interactive
> (when current-prefix-arg
> (list (read-string "Remote location (empty for default): "))))
>
> So a prefix argument followed by pressing enter.
>
> Dmitry> Should we maybe just change the callers to always use one or the other
> Dmitry> value?
>
> Seems reasonable, I'll change vc-log-outgoing.
Thanks.
> As you say, point ends up at eob due to vc-do-command using process-file
> in the synchronous case; whereas for the async case, vc-process-filter
> uses save-excursion.
Yes, and it's a problem we need to fix either way.
> The other behavior seems to be a problem in
> shrink-window-if-larger-than-buffer. I can reproduce it easily just
> with any buffer by moving point to the end. I didn't debug this any
> further than finding that.
Might want to look into that sometime. I've tried that in different
configurations, and 'M-x shrink-window-if-larger-than-buffer' doesn't do
anything if the buffer is longer than the current window height.
If it's shorter, the window gets shrunk appropriately, with only the
off-by-one scrolling problem.
next prev parent reply other threads:[~2017-02-20 1:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-15 12:38 bug#25737: 25.1.91; vc-git-log-{incoming,outgoing} fixes Tom Tromey
2017-02-16 10:48 ` Dmitry Gutov
2017-02-17 4:01 ` Tom Tromey
2017-02-20 1:53 ` Dmitry Gutov [this message]
2017-02-17 4:05 ` Tom Tromey
2017-02-20 1:53 ` Dmitry Gutov
2017-02-25 4:03 ` bug#25737: done Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4da6d3e1-a57d-dad9-55db-e4549cf0d280@yandex.ru \
--to=dgutov@yandex.ru \
--cc=25737@debbugs.gnu.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.