From: Reuben Thomas <rrt@sc3d.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 28179@debbugs.gnu.org
Subject: bug#28179: Fwd: Re: bug#28179: Fix use of string-to-multibyte in ispell.el
Date: Thu, 24 Aug 2017 18:45:33 +0100 [thread overview]
Message-ID: <4d1a7990-f076-9e22-39df-6edeef17ef7b@sc3d.org> (raw)
In-Reply-To: <83lgm89a1v.fsf@gnu.org>
On 24/08/17 17:59, Eli Zaretskii wrote:
>> From: Reuben Thomas <rrt@sc3d.org>
>> Date: Wed, 23 Aug 2017 11:59:41 +0100
>>
>> I now understand the two meanings of "multibyte", but I don't understand
>> how my patch is deficient.
> I didn't say it was deficient,
Sorry, I was unclear. I meant, precisely, I don't see why you think my
patch's code returns a string that is not multibyte.
> I asked whether you verified that
> either (a) the result is always multibyte
I believe I showed this is the case.
>
>> So in fact even when the string isn't copied (as in my patch, where I
>> also use a third argument of t to decode-coding-string) it appears to be
>> changed to a multibyte string.
> Fine, if you are sure, go ahead and push.
>
The reason I am asking again is because you first said:
> What if decode-coding-string returns a pure ASCII string, which is
> therefore unibyte?
and then later you said:
> The way I meant it, it has to do with the internal flag marking a
> string either unibyte or multibyte. Observe:
> (multibyte-string-p "abcd") => nil
>
> but
>
> (multibyte-string-p (decode-coding-string "abcd" 'utf-8)) => t
In other words:
1. As far as I can tell from the above (and my own confirmatory
experiments and reading of the documentation), a pure ASCII string can
be multibyte (it's a matter of the multibyte flag, not the number of
bytes used to store each character).
2. decode-coding-string always returns a multibyte string.
Since these two observations seemed to mean that you contradicted
yourself, I was checking whether in fact I had misunderstood (so that
for example one of my two observations above is wrong), or if your
original understanding was incomplete (so that in fact your question
about decode-coding-string is therefore misguided, because it can return
a pure ASCII unibyte string (in the coding sense) which is nonetheless a
multibyte string (in the sense that multibyte-string-p on it returns t).
Sorry about the miscommunication. In any case, I think the code is
correct, your original question was misguided, and I shall push, with,
as Noam requested in another message, an explanation of my assumptions.
No need to reply further unless you think there really is a problem!
--
https://rrt.sc3d.org
next prev parent reply other threads:[~2017-08-24 17:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <f64ac7bd-9952-c09a-71df-f1e123407cff@sc3d.org>
2017-08-23 10:59 ` bug#28179: Fwd: Re: bug#28179: Fix use of string-to-multibyte in ispell.el Reuben Thomas
2017-08-24 16:59 ` Eli Zaretskii
2017-08-24 17:32 ` Noam Postavsky
2017-08-24 17:45 ` Reuben Thomas [this message]
2017-08-24 18:20 ` Eli Zaretskii
2017-08-24 18:50 ` Reuben Thomas
2017-08-24 19:02 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d1a7990-f076-9e22-39df-6edeef17ef7b@sc3d.org \
--to=rrt@sc3d.org \
--cc=28179@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.