all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: 28978@debbugs.gnu.org
Subject: bug#28978: 26.0; Regression: separate, dedicated `*Completions*' frame no longer has parameter `minibuffer'
Date: Tue, 24 Oct 2017 13:20:17 -0700 (PDT)	[thread overview]
Message-ID: <4d0c5535-246a-4356-914f-3c8d030ba9c9@default> (raw)

In my code I check (essentially) this:

(let ((swin  (selected-window)))
  (when (window-minibuffer-p swin) (setq swin  (minibuffer-selected-window)))
  (and (get-buffer-window "*Completions*")
       (window-live-p swin)
       (not (eq (window-buffer swin) (get-buffer "*Completions*")))
       (interactive-p)))

It does what I expect in all Emacs releases, but not in this
prerelease.  My `*Completions*' window is in its own one-window frame,
with the window dedicated.  Input for that frame is redirected to my
standalone minibuffer frame.

It should be the case in my context that this returns the minibuffer
window:

(cdr (assoc 'minibuffer (frame-parameters
                          (#<frame *Completions* 000000000cacf6c8>))))

Instead, it now returns nil.  Parameter `minibuffer' for the
`*Completions*' frame is no longer the minibuffer window; it is nil.

This is the code that redirects the frame focus, which I guess is
relevant:

(let ((redirect  (if (active-minibuffer-window)
                     1on1-minibuffer-frame
                   (and completion-reference-buffer
                        (get-buffer-window completion-reference-buffer 'visible)
                        (not (eq (get-buffer "*Completions*") completion-reference-buffer))
                        (window-frame (get-buffer-window completion-reference-buffer t))))))
  (when redirect (redirect-frame-focus (selected-frame) redirect)))

That code is in a function, `1on1-display-*Completions*-frame',
that I use with `special-display-buffer-names':

(add-to-list 'special-display-buffer-names
             `("*Completions*" 1on1-display-*Completions*-frame
               ((background-color ,@1on1-completions-frame-background)
                (mouse-color      ,@1on1-completions-frame-mouse+cursor-color)
                (cursor-color     ,@1on1-completions-frame-mouse+cursor-color)
                (menu-bar-lines . 0) (tool-bar-lines . 0) ; No menu bar or tool bar.
                ,@(and 1on1-completions-frame-width
                       `((width   ,@1on1-completions-frame-width))))))

In GNU Emacs 26.0.90 (build 3, x86_64-w64-mingw32)
 of 2017-10-13
Repository revision: 906224eba147bdfc0514090064e8e8f53160f1d4
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --without-dbus --host=x86_64-w64-mingw32
 --without-compress-install 'CFLAGS=-O2 -static -g3''





             reply	other threads:[~2017-10-24 20:20 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-24 20:20 Drew Adams [this message]
2017-10-25  7:45 ` bug#28978: 26.0; Regression: separate, dedicated `*Completions*' frame no longer has parameter `minibuffer' martin rudalics
2017-10-25 14:47   ` Drew Adams
2017-10-26  7:57     ` martin rudalics
2017-10-26 14:01       ` Drew Adams
2017-10-27  8:25         ` martin rudalics
2017-10-27 14:19           ` Drew Adams
2017-10-28  8:45             ` martin rudalics
2017-10-28 19:15               ` Drew Adams
2017-10-29 11:18                 ` martin rudalics
2017-10-29 15:59                   ` Drew Adams
2017-10-29 18:13                     ` martin rudalics
2017-10-29 23:56                       ` Drew Adams
2017-10-30  8:24                         ` martin rudalics
2017-10-30 14:32                           ` Drew Adams
2017-10-30 19:00                             ` martin rudalics
2017-10-30 19:16                               ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4d0c5535-246a-4356-914f-3c8d030ba9c9@default \
    --to=drew.adams@oracle.com \
    --cc=28978@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.