From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: master 3843711 3/3: Simplify calculator-expt Date: Tue, 5 Nov 2019 13:47:19 -0800 Organization: UCLA Computer Science Department Message-ID: <4cd7e850-3fd8-5adc-8231-4604d1268fd8@cs.ucla.edu> References: <20191105073959.21509.71385@vcs0.savannah.gnu.org> <20191105074004.5063220A3C@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="73403"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 05 23:02:34 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iS6uI-000IkB-7f for ged-emacs-devel@m.gmane.org; Tue, 05 Nov 2019 23:02:34 +0100 Original-Received: from localhost ([::1]:50806 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iS6uG-0006pF-U0 for ged-emacs-devel@m.gmane.org; Tue, 05 Nov 2019 17:02:32 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49239) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iS6fg-0001jb-V4 for emacs-devel@gnu.org; Tue, 05 Nov 2019 16:47:29 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iS6ff-00045X-Mo for emacs-devel@gnu.org; Tue, 05 Nov 2019 16:47:28 -0500 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:38562) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iS6fe-00043O-0t for emacs-devel@gnu.org; Tue, 05 Nov 2019 16:47:27 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 96DBF1604EB; Tue, 5 Nov 2019 13:47:21 -0800 (PST) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id h1_00MDnDoyT; Tue, 5 Nov 2019 13:47:20 -0800 (PST) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 543E5160511; Tue, 5 Nov 2019 13:47:20 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id L1vybIk1ctiM; Tue, 5 Nov 2019 13:47:20 -0800 (PST) Original-Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 3880E1604EB; Tue, 5 Nov 2019 13:47:20 -0800 (PST) In-Reply-To: Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:241824 Archived-At: On 11/5/19 11:29 AM, Stefan Monnier wrote: >> + (if (or (natnump x) (cl-evenp y)) > > `cl-evenp` doesn't do the `truncate` part, so this will signal an error if > `x` is not a natural number and `y` is not an integer. Not a problem, as this part of the code is reachable only if Y is an integer. I added a comment to that effect.