From: Paul Eggert <eggert@cs.ucla.edu>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: master 3843711 3/3: Simplify calculator-expt
Date: Tue, 5 Nov 2019 13:47:19 -0800 [thread overview]
Message-ID: <4cd7e850-3fd8-5adc-8231-4604d1268fd8@cs.ucla.edu> (raw)
In-Reply-To: <jwvr22m9l90.fsf-monnier+emacs@gnu.org>
On 11/5/19 11:29 AM, Stefan Monnier wrote:
>> + (if (or (natnump x) (cl-evenp y))
>
> `cl-evenp` doesn't do the `truncate` part, so this will signal an error if
> `x` is not a natural number and `y` is not an integer.
Not a problem, as this part of the code is reachable only if Y is an
integer. I added a comment to that effect.
next prev parent reply other threads:[~2019-11-05 21:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191105073959.21509.71385@vcs0.savannah.gnu.org>
[not found] ` <20191105074004.5063220A3C@vcs0.savannah.gnu.org>
2019-11-05 11:28 ` master 3843711 3/3: Simplify calculator-expt Juanma Barranquero
2019-11-05 21:45 ` Paul Eggert
2019-11-05 19:29 ` Stefan Monnier
2019-11-05 21:47 ` Paul Eggert [this message]
2020-04-16 20:36 jakub-w
2020-04-16 20:56 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4cd7e850-3fd8-5adc-8231-4604d1268fd8@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.