From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: =?UTF-8?Q?Rami_Ylim=c3=a4ki?= Newsgroups: gmane.emacs.devel Subject: Re: [PATCH 0/1] Proper 24-bit TTY detection for Emacs 26. Date: Mon, 29 Jan 2018 15:27:37 +0200 Message-ID: <4ba09000-896f-9950-f99c-f46f431f490f@vincit.fi> References: <20180123200536.26554-1-rami.ylimaki@vincit.fi> <831sifnlsc.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1517232434 17957 195.159.176.226 (29 Jan 2018 13:27:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 29 Jan 2018 13:27:14 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jan 29 14:27:09 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eg9SV-0003EM-AQ for ged-emacs-devel@m.gmane.org; Mon, 29 Jan 2018 14:26:51 +0100 Original-Received: from localhost ([::1]:37934 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eg9UT-0006qQ-W3 for ged-emacs-devel@m.gmane.org; Mon, 29 Jan 2018 08:28:54 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59234) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eg9TN-0006oJ-2d for emacs-devel@gnu.org; Mon, 29 Jan 2018 08:27:46 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eg9TJ-0003w0-4G for emacs-devel@gnu.org; Mon, 29 Jan 2018 08:27:45 -0500 Original-Received: from mail-lf0-x231.google.com ([2a00:1450:4010:c07::231]:46994) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eg9TI-0003v5-Ss for emacs-devel@gnu.org; Mon, 29 Jan 2018 08:27:41 -0500 Original-Received: by mail-lf0-x231.google.com with SMTP id q194so9936257lfe.13 for ; Mon, 29 Jan 2018 05:27:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vincit.fi; s=ticniv; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=LbSS3pc12OQlDk3O5pe7Ptd1ll5Hb2csyE+y2Tpau+Q=; b=TWxYOsc3jXyXAczTA9j53WTCAn6IKpebwla4SLCR9xmKRGdXPK8WTk3wA3xdQzR7w2 P5dpw6lJNXgIRuoScUQQTjr5FOJOYrXMMxvQugMTMH0B7uayfee+BPr75Ypx2nnoVJQI X52Rm0dFC6unG2xBD8fbUjIhRRxl2p4qzfW1o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=LbSS3pc12OQlDk3O5pe7Ptd1ll5Hb2csyE+y2Tpau+Q=; b=G2elltFN4sv6h/4UVzZfKx6+pUVAFkXZvm6JGanrz7vHjSoOBMIM8Y4L1e22DjFtF1 3tfPenk10AevLZZC/zsJ36mycmmhZMLfoEgujk6XYq5mgU3VKpkArimw8Lnonzv6H++q OXSYok0nNtHSLPdKQfcjz4hTbIosi2rPmyxUYXisEg/z4JgeTxbFNgg2L8+5D8VSvnuG yWqT8Fmcu2FAvpFyFGdUOn15KqvugVMWnN1cOFIwnKTCa7vAX90S+8E1c2YgSYNJilUG qxvX786G150a99kDJ6jEDat8VeJsgo6iJF262jJcjVFBK3pnBuvKZQ8sEL7eFaQHARm8 NErQ== X-Gm-Message-State: AKwxytd+KykhUW8U1vTFq1+8DaApAEBe+FUXmpU1tx1I7bpfFIG/94Sb kh9WjOcuZsnyDxKQv1RMrLw+xArlgPk= X-Google-Smtp-Source: AH8x227yrAMpsHPD0A8VgN6xdocReg7cpWz6BBWx/0JsJsCBE3Bc0wV2RVpMCMw+aPQB9V2pShZ+5w== X-Received: by 10.25.211.7 with SMTP id k7mr12209111lfg.118.1517232458979; Mon, 29 Jan 2018 05:27:38 -0800 (PST) Original-Received: from [10.138.224.161] (gw.vincit.cloud. [195.60.252.249]) by smtp.gmail.com with ESMTPSA id r22sm1792837lje.12.2018.01.29.05.27.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 29 Jan 2018 05:27:38 -0800 (PST) In-Reply-To: <831sifnlsc.fsf@gnu.org> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4010:c07::231 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:222293 Archived-At: > It's too late to make incompatible changes on the emacs-26 branch. > > I actually don't understand the motivation for the change. Did the > method we use now stop working in the recent versions of terminfo, and > the "RGB" and "setaf"/"setab" replace "setf24"/"setb24" we use in the > current code? Or are the new attributes supported in addition to the > old ones? If the latter, why do we need to change anything? And if > the former, I think we want to support both, not just the new > replacements. The "set[bf]24" capabilities are only supported by Emacs, because traditionally Terminfo hasn't offered any way to detect direct color support. This workaround forces users to compile their own TERMs with these capabilities. Latest Terminfo provides several TERMs with "-direct" suffix, such as "xterm-direct", that support "RGB" with "seta[bf]". We definitely want to support this. I can open a bug about this and post a patch that supports both methods on Emacs 27, since it's too late for 26. There might be some problems with Emacs 26 and TERM=xterm-direct, but I haven't properly investigated this yet. At least I already noticed some error messages from xterm.el:xterm-register-default-colors.