From: "Rami Ylimäki" <rami.ylimaki@vincit.fi>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH 0/1] Proper 24-bit TTY detection for Emacs 26.
Date: Mon, 29 Jan 2018 15:27:37 +0200 [thread overview]
Message-ID: <4ba09000-896f-9950-f99c-f46f431f490f@vincit.fi> (raw)
In-Reply-To: <831sifnlsc.fsf@gnu.org>
> It's too late to make incompatible changes on the emacs-26 branch.
>
> I actually don't understand the motivation for the change. Did the
> method we use now stop working in the recent versions of terminfo, and
> the "RGB" and "setaf"/"setab" replace "setf24"/"setb24" we use in the
> current code? Or are the new attributes supported in addition to the
> old ones? If the latter, why do we need to change anything? And if
> the former, I think we want to support both, not just the new
> replacements.
The "set[bf]24" capabilities are only supported by Emacs, because
traditionally Terminfo hasn't offered any way to detect direct color
support. This workaround forces users to compile their own TERMs with
these capabilities.
Latest Terminfo provides several TERMs with "-direct" suffix, such as
"xterm-direct", that support "RGB" with "seta[bf]". We definitely want
to support this.
I can open a bug about this and post a patch that supports both methods
on Emacs 27, since it's too late for 26.
There might be some problems with Emacs 26 and TERM=xterm-direct, but I
haven't properly investigated this yet. At least I already noticed some
error messages from xterm.el:xterm-register-default-colors.
next prev parent reply other threads:[~2018-01-29 13:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-23 20:05 [PATCH 0/1] Proper 24-bit TTY detection for Emacs 26 Rami Ylimäki
2018-01-23 20:05 ` [PATCH 1/1] Detect 24-bit TTY color support with standard Terminfo capabilites Rami Ylimäki
2018-01-24 18:39 ` [PATCH 0/1] Proper 24-bit TTY detection for Emacs 26 Eli Zaretskii
2018-01-29 13:27 ` Rami Ylimäki [this message]
2018-01-29 15:59 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ba09000-896f-9950-f99c-f46f431f490f@vincit.fi \
--to=rami.ylimaki@vincit.fi \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.