From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Vibhav Pant Newsgroups: gmane.emacs.devel Subject: Re: feature/comp-use-ctors 1b48e8dde5: src/comp.c: Use constructor expressions when possible. Date: Fri, 14 Oct 2022 18:28:39 +0530 Message-ID: <4b63673d4a922066e9fd3a549ae6020cff4085e3.camel@gmail.com> References: <166574864429.19305.16697125442242926452@vcs2.savannah.gnu.org> <20221014115724.B04FCC1AB4A@vcs2.savannah.gnu.org> <87a65y7git.fsf@yahoo.com> Reply-To: vibhavp@gmail.com Mime-Version: 1.0 Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-Lhr6cljmW+8qeAfrg8VZ" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23279"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Evolution 3.44.4 To: Po Lu , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Oct 14 15:03:24 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ojKLT-0005on-1G for ged-emacs-devel@m.gmane-mx.org; Fri, 14 Oct 2022 15:03:23 +0200 Original-Received: from localhost ([::1]:39092 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ojKLR-0008PL-Lm for ged-emacs-devel@m.gmane-mx.org; Fri, 14 Oct 2022 09:03:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38662) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ojKH2-0006LR-59 for emacs-devel@gnu.org; Fri, 14 Oct 2022 08:58:49 -0400 Original-Received: from mail-pl1-x630.google.com ([2607:f8b0:4864:20::630]:45871) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ojKH0-00019V-JO for emacs-devel@gnu.org; Fri, 14 Oct 2022 08:58:47 -0400 Original-Received: by mail-pl1-x630.google.com with SMTP id i6so4625287pli.12 for ; Fri, 14 Oct 2022 05:58:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:references:in-reply-to:date:to:reply-to :from:subject:message-id:from:to:cc:subject:date:message-id:reply-to; bh=BNQnUvCcz0Ym6+tk2dda1nRKCPrzXPmbms9XfwH2758=; b=NBtnzYPa8WK4cSBMLs6fn5cpPhgvK2heNrKUGEYnCWQnf2Xl/N0sB8hDRVP0RqRsPD NbB/8eaOcdTuFifqRHv07OZRhSI9xQiuG/ACEuJVeQ2gJY5N9j8jWW7zw6yAOLsoJeXi dKS95VeER48oDCxZvvbJHSdNQWWgXd93wr/mG9cbIkv392pk/SMDhTAUNeLhfsyW1JrO Xf9O1LG4tcozr+oCvfl5V4iRtL2ykuDIEIUCqtcmUTmn4it7cgOzmTk5iEygd7XtWEAq c73//QtM6kECmEZH0AqbDQUM3tYj0rvIT6IQLrcwqRKlcjbIexmW/F7PcfdnXa0lCbM8 8Xww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:references:in-reply-to:date:to:reply-to :from:subject:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BNQnUvCcz0Ym6+tk2dda1nRKCPrzXPmbms9XfwH2758=; b=WpJ3uc2OM7D4UnX9v2mTJ3Q8tD60DBYUk1/s5rUvHP8NBixevrYbv7HUEqMCS+HTLg U5q7ayy+PLy7Fp93ThFGx42CE+GxkzZkkwGE0WlO3KmXClHHpkTtMneuAUR9xY4GZgPS 9v3qRVOAITzddF1jDVjtDL/C59z3/IBCEr3CBtB1UUIy7opMthiOqIpfeFaWZ4wa+R1d eAaQewGlBe6Q94wUsDmexGg0WDJovRO1etxU9Q0jNwlAihtkQ2d/7h3h+T5viEeHnLLI LAzwF38iqHh3lGzSKSkiy60Yo6Wp2BXTaky8YLhzKR1Rf1SY8B7w0w70gvcUivx0zX7N pfTw== X-Gm-Message-State: ACrzQf1WY8SJoGsClJOGdHUqQwgSJ1yy35CXBtptYkppLEUmrWcA0JJd WeK6TzTG2hDpv/SCpUMtVdM= X-Google-Smtp-Source: AMsMyM5rddB0/gyAVMHrtB5J/8jzZ0mWQ8IDexQkOW71U6ImbeCtdowdtBmxl/FXg6BnSBzGLzjeQQ== X-Received: by 2002:a17:902:7fc6:b0:185:428c:b9c0 with SMTP id t6-20020a1709027fc600b00185428cb9c0mr3349765plb.116.1665752323550; Fri, 14 Oct 2022 05:58:43 -0700 (PDT) Original-Received: from ?IPv6:2401:4900:1f35:f07a:2076:9761:4b36:7997? ([2401:4900:1f35:f07a:2076:9761:4b36:7997]) by smtp.gmail.com with ESMTPSA id r16-20020a63e510000000b004308422060csm1393449pgh.69.2022.10.14.05.58.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Oct 2022 05:58:42 -0700 (PDT) In-Reply-To: <87a65y7git.fsf@yahoo.com> Received-SPF: pass client-ip=2607:f8b0:4864:20::630; envelope-from=vibhavp@gmail.com; helo=mail-pl1-x630.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:297720 Archived-At: --=-Lhr6cljmW+8qeAfrg8VZ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2022-10-14 at 20:10 +0800, Po Lu wrote: > Vibhav Pant writes: >=20 > > branch: feature/comp-use-ctors > > commit 1b48e8dde5bfee65c036fbfdc32b68c9093c2e06 > > Author: Vibhav Pant > > Commit: Vibhav Pant > >=20 > > =C2=A0=C2=A0=C2=A0 src/comp.c: Use constructor expressions when possibl= e. > > =C2=A0=C2=A0=C2=A0=20 > > =C2=A0=C2=A0=C2=A0 * src/comp.c: > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - Add declarations for creating construc= tor/initializer > > expressions > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 when supported. > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - (emit_coerce): Use a struct constructo= r expression to > > create a > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Lisp_Object value instead of creating a = new local variable. > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - emit_limple_call_ref: Emit a single co= nstructor expression > > for > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 initializing tmp_arr. >=20 > This is not how we write commit messages; it should be: >=20 > * src/comp.c: Add declarations for creating > constructor/initializer expressions when supported. > (emit_coerce): Use a struct constructor expression to create a > Lisp_Object value instead of creating a new local variable. > (emit_limple_call_ref): Emit a single constructor expression for > initializing tmp_arr. >=20 > Keep in mind that the commit message must also be filled to 64 > columns. Ah, knew something about it was off. Thanks :) --=20 Vibhav Pant vibhavp@gmail.com GPG: 7ED1 D48C 513C A024 BE3A 785F E3FB 28CB 6AB5 9598 --=-Lhr6cljmW+8qeAfrg8VZ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEftHUjFE8oCS+Onhf4/soy2q1lZgFAmNJXP8ACgkQ4/soy2q1 lZg2mAf/W3gnkIE1MnEsLxcqxFedzRdCUfibuQ5FbgXTkahbfPiZRI3wNRNAON14 bJgmWAwlTssjObuh0JFlqWDm/aDoJsEBk9sPsSBlKtxiTOqW0/QJyXkCmq2SE4Xi n0l/zfk5GzVVzuv47zU1JwsbvZyF/iMoTznNDLNDkCQpcEdcL0wH20BA0MrPOXlw N7oviIDTW6wlXhWs0KE1Ueorp/XREq9kqAYIG0Z6ICVnp4SvwBcp7Soa/O0U4Cto VMqyCNq22C62YBiDbZmYn/y81oxNdvygiu+5hXsTF3k+EK7iJXTIxnsAYMdO3gfA 6/QaUmtct5VHrABy8wXhSmiykji/UQ== =VacB -----END PGP SIGNATURE----- --=-Lhr6cljmW+8qeAfrg8VZ--