Re: feature/comp-use-ctors 1b48e8dde5: src/comp.c: Use constructor expressions when possible.

Re: feature/comp-use-ctors 1b48e8dde5: src/comp.c: Use constructor expressions when possible.

[Po Lu]

Vibhav Pant <vibhavp@gmail.com> writes:

> branch: feature/comp-use-ctors
> commit 1b48e8dde5bfee65c036fbfdc32b68c9093c2e06
> Author: Vibhav Pant <vibhavp@gmail.com>
> Commit: Vibhav Pant <vibhavp@gmail.com>
>
>     src/comp.c: Use constructor expressions when possible.
>     
>     * src/comp.c:
>       - Add declarations for creating constructor/initializer expressions
>       when supported.
>       - (emit_coerce): Use a struct constructor expression to create a
>       Lisp_Object value instead of creating a new local variable.
>       - emit_limple_call_ref: Emit a single constructor expression for
>       initializing tmp_arr.

This is not how we write commit messages; it should be:

* src/comp.c: Add declarations for creating
constructor/initializer expressions when supported.
(emit_coerce): Use a struct constructor expression to create a
Lisp_Object value instead of creating a new local variable.
(emit_limple_call_ref): Emit a single constructor expression for
initializing tmp_arr.

Keep in mind that the commit message must also be filled to 64 columns.

Re: feature/comp-use-ctors 1b48e8dde5: src/comp.c: Use constructor expressions when possible.

[Vibhav Pant]

[-- Attachment #1: Type: text/plain, Size: 1415 bytes --]

On Fri, 2022-10-14 at 20:10 +0800, Po Lu wrote:
> Vibhav Pant <vibhavp@gmail.com> writes:
> 
> > branch: feature/comp-use-ctors
> > commit 1b48e8dde5bfee65c036fbfdc32b68c9093c2e06
> > Author: Vibhav Pant <vibhavp@gmail.com>
> > Commit: Vibhav Pant <vibhavp@gmail.com>
> > 
> >     src/comp.c: Use constructor expressions when possible.
> >     
> >     * src/comp.c:
> >       - Add declarations for creating constructor/initializer
> > expressions
> >       when supported.
> >       - (emit_coerce): Use a struct constructor expression to
> > create a
> >       Lisp_Object value instead of creating a new local variable.
> >       - emit_limple_call_ref: Emit a single constructor expression
> > for
> >       initializing tmp_arr.
> 
> This is not how we write commit messages; it should be:
> 
> * src/comp.c: Add declarations for creating
> constructor/initializer expressions when supported.
> (emit_coerce): Use a struct constructor expression to create a
> Lisp_Object value instead of creating a new local variable.
> (emit_limple_call_ref): Emit a single constructor expression for
> initializing tmp_arr.
> 
> Keep in mind that the commit message must also be filled to 64
> columns.

Ah, knew something about it was off. Thanks :)


-- 
Vibhav Pant
vibhavp@gmail.com
GPG: 7ED1 D48C 513C A024 BE3A  785F E3FB 28CB 6AB5 9598

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: feature/comp-use-ctors 1b48e8dde5: src/comp.c: Use constructor expressions when possible.

[Robert Pluim]

>>>>> On Fri, 14 Oct 2022 18:28:39 +0530, Vibhav Pant <vibhavp@gmail.com> said:

    Vibhav> On Fri, 2022-10-14 at 20:10 +0800, Po Lu wrote:
    >> This is not how we write commit messages; it should be:
    >> 
    >> * src/comp.c: Add declarations for creating
    >> constructor/initializer expressions when supported.
    >> (emit_coerce): Use a struct constructor expression to create a
    >> Lisp_Object value instead of creating a new local variable.
    >> (emit_limple_call_ref): Emit a single constructor expression for
    >> initializing tmp_arr.
    >> 
    >> Keep in mind that the commit message must also be filled to 64
    >> columns.

    Vibhav> Ah, knew something about it was off. Thanks :)

See also "** Generating ChangeLog entries" in CONTRIBUTE, it describes
Emacs facilities to help here.

Robert
--