From: Harald Judt <h.judt@gmx.at>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: [ELPA] New package: dired-duplicates
Date: Thu, 9 Nov 2023 10:18:59 +0100 [thread overview]
Message-ID: <4ab1a8ce-f07f-46a2-9fb5-2eff83fb70d7@gmx.at> (raw)
In-Reply-To: <831qcz1fm3.fsf@gnu.org>
[-- Attachment #1.1: Type: text/plain, Size: 1796 bytes --]
On 2023-11-09 at 09:43, Eli Zaretskii wrote:>> Date: Thu, 9 Nov 2023 09:00:11
+0100
>> Cc: emacs-devel@gnu.org
>> From: Harald Judt <h.judt@gmx.at>
>>
>>> The size limitation should have its default value dependent on whether
>>> the build is a 32-bit (which we still support) or 64-bit. You can
>>> look at how we compute treesit-max-buffer-size, to figure out how to
>>> express the conditions for the default value.
>>
>> Yes, but I wonder, why do this? There can be 32-bit systems as well as 64-bit
>> systems that can have only 2GiB RAM, both might fail when trying to open a
>> file that has e.g. 1536MiB. Then, there might be both types of systems that
>> have 8gb of RAM that can open such files with no problems?
>
> If you are saying that we can do with a single value, I'm okay with
> that, provided that this value will be accepted by users. 32-bit
> systems cannot have buffers larger than 2 GiB, and a reasonable limit
> would be something like 500 MiB, I think. This could be too low for
> users of 64-bit systems, but if it's okay, it's fine with me. Your
> proposed default, 1 GiB, is too large for a typical 32-bit system,
> IMO.
>
>> Maybe it would be possible to make it dependent on the amount of RAM available
>> on the system?
>
> Ideally, yes, but in practice knowing how much is available is not
> that easy on a modern OS, so I don't think it's worth the hassle,
> especially in fallback code.
I agree, 500M for 32-bit and 1G for 64-bit are good defaults for the
dired-duplicates use-case, I guess most typical systems will be able to handle
it. I will implement it this way.
Harald
--
`Experience is the best teacher.'
PGP Key ID: 4FFFAB21B8580ABD
Fingerprint: E073 6DD8 FF40 9CF2 0665 11D4 4FFF AB21 B858 0ABD
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-11-09 9:18 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-31 10:34 [ELPA] New package: dired-duplicates Harald Judt
2023-10-31 12:21 ` Philip Kaludercic
2023-10-31 21:05 ` Harald Judt
2023-11-01 2:14 ` Michael Heerdegen
2023-11-01 15:16 ` [External] : " Drew Adams
2023-11-01 15:45 ` Eli Zaretskii
2023-11-01 16:28 ` Drew Adams
2023-11-01 16:47 ` Eli Zaretskii
2023-11-01 16:33 ` Philip Kaludercic
2023-11-01 11:32 ` Philip Kaludercic
2023-11-01 20:04 ` Harald Judt
2023-11-01 21:29 ` Philip Kaludercic
2023-11-02 8:44 ` Harald Judt
2023-11-03 8:19 ` Philip Kaludercic
2023-11-03 20:19 ` Harald Judt
2023-11-04 15:27 ` Philip Kaludercic
2023-11-06 9:33 ` Harald Judt
2023-11-10 8:37 ` Philip Kaludercic
2023-11-10 10:02 ` Harald Judt
2023-11-23 6:12 ` Philip Kaludercic
2023-10-31 21:24 ` Harald Judt
2023-11-01 17:40 ` Stefan Kangas
2023-11-01 3:30 ` Eli Zaretskii
2023-11-01 13:53 ` Visuwesh
2023-11-01 14:12 ` Eli Zaretskii
2023-11-01 17:57 ` Philip Kaludercic
2023-11-01 19:24 ` Eli Zaretskii
2023-11-01 20:09 ` Harald Judt
2023-11-02 5:55 ` Eli Zaretskii
2023-11-08 20:29 ` Harald Judt
2023-11-09 5:52 ` Eli Zaretskii
2023-11-09 8:00 ` Harald Judt
2023-11-09 8:38 ` tomas
2023-11-09 8:48 ` Eli Zaretskii
2023-11-09 8:43 ` Eli Zaretskii
2023-11-09 8:53 ` tomas
2023-11-09 9:18 ` Harald Judt [this message]
2023-11-09 14:52 ` Harald Judt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ab1a8ce-f07f-46a2-9fb5-2eff83fb70d7@gmx.at \
--to=h.judt@gmx.at \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.