all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: Alex Griffin <a@ajgrf.com>, 52986@debbugs.gnu.org
Subject: bug#52986: 29.0.50; tab bar doesn't immediately show
Date: Sun, 23 Jan 2022 11:15:49 +0100	[thread overview]
Message-ID: <4a8ccc49-96b4-bc02-99ee-56dddc2b3877@gmx.at> (raw)
In-Reply-To: <87k0ernzlp.fsf@ajgrf.com>

 > I think I'm also hitting this issue just by docking Emacs to the side in
 > GNOME Shell. I've set 'frame-inhibit-implied-resize' to t, but Emacs
 > still wants to resize the frame when initializing tab-bar-mode.

'frame-inhibit-implied-resize' defaults to '(tab-bar-lines) so you don't
even have to change its value.  What you see is the following: It's a
long established practice that people want their frames initially have
a specified number of lines, disregarding the height of things like the
tool or tab bar.  To do that, Emacs calculates the initial pixel height
of a GUI frame from the number of lines specified for it plus the pixel
heights of a tool and tab bar, if present.

Now the code that adds the latter ('x_change_tab_bar_height') uses two
boolean slots for each frame - tab_bar_resized and tab_bar_redisplayed -
both initially false.  The latter is set by the display engine in
redisplay_tab_bar to indicate that the tab bar has been redisplayed once
so its pixel height has been established.  The former is then set by
'x_change_tab_bar_height' from the latter.  As long as tab_bar_resized
has not been set for a specific frame, 'frame-inhibit-implied-resize'
has no effect - Emacs will ask the window manager to resize it.

 > I'm currently using Emacs 29.0.50 for the new GTK/Wayland support, and I
 > don't see the same issue on Emacs 28.0.91.

You should see it on Emacs 28.  Only if you start Emacs with tab bar
mode enabled initially you should not see it.

martin





  reply	other threads:[~2022-01-23 10:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-03 19:15 bug#52986: 29.0.50; tab bar doesn't immediately show Dustin Lacewell
2022-01-03 19:39 ` Eli Zaretskii
     [not found]   ` <CAMDmBpH-+Vt+Wf2PzFHYsLQRWwd9bT-AEkwr2SMdtMESG6e0gg@mail.gmail.com>
2022-01-03 20:04     ` Eli Zaretskii
2022-01-04  8:51       ` martin rudalics
2022-01-04  1:08 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-04  8:51 ` martin rudalics
2022-01-22 23:02 ` Alex Griffin via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-23 10:15   ` martin rudalics [this message]
2022-01-24  9:52   ` martin rudalics
2022-02-21 14:22     ` Lars Ingebrigtsen
2022-01-24  9:52 ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4a8ccc49-96b4-bc02-99ee-56dddc2b3877@gmx.at \
    --to=rudalics@gmx.at \
    --cc=52986@debbugs.gnu.org \
    --cc=a@ajgrf.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.