From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#59935: 29.0.60; project-list-buffers is slow Date: Sat, 10 Dec 2022 21:22:20 +0200 Message-ID: <4a78ffcc-15fb-27ac-48b9-82fe84c596aa@yandex.ru> References: <86a63vi2lu.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18068"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Cc: 59935@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 10 20:23:16 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p45RM-0004Ut-J8 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 10 Dec 2022 20:23:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p45R9-0005Mh-9Y; Sat, 10 Dec 2022 14:23:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p45R8-0005MS-3n for bug-gnu-emacs@gnu.org; Sat, 10 Dec 2022 14:23:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p45R7-0001NA-SO for bug-gnu-emacs@gnu.org; Sat, 10 Dec 2022 14:23:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p45R7-0004y5-NK for bug-gnu-emacs@gnu.org; Sat, 10 Dec 2022 14:23:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Dec 2022 19:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59935 X-GNU-PR-Package: emacs Original-Received: via spool by 59935-submit@debbugs.gnu.org id=B59935.167070015319071 (code B ref 59935); Sat, 10 Dec 2022 19:23:01 +0000 Original-Received: (at 59935) by debbugs.gnu.org; 10 Dec 2022 19:22:33 +0000 Original-Received: from localhost ([127.0.0.1]:44596 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p45Qf-0004xX-Gg for submit@debbugs.gnu.org; Sat, 10 Dec 2022 14:22:33 -0500 Original-Received: from mail-wr1-f51.google.com ([209.85.221.51]:46737) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p45Qa-0004xN-09 for 59935@debbugs.gnu.org; Sat, 10 Dec 2022 14:22:32 -0500 Original-Received: by mail-wr1-f51.google.com with SMTP id h11so8256649wrw.13 for <59935@debbugs.gnu.org>; Sat, 10 Dec 2022 11:22:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=hNA3XTS5DPSVyhTn9bRvz8ndXP6Z0e0MigidvKOT658=; b=eNcwUoNzbXo2/0ldusv9rnsM0/VH8Yt3T0ogWUQ/Lme/w+qAHlGxxc7uIWA5iHdjKR BrJ34vTvcV7moQ9882xOYYRTIhYezAKfNabCh5BKbVxsmTw0edRyyTKaGl0ytN1eIYvy 04V1Xa+QzwF7cJPIOG7frheifMNpwEyGF6nXfNjnBS/4a6HAM9y6AehzkLTf3riyKo+w HO7FLgAAab1cv93ISmL+ew/hfpJ43JQjnahijbu+PeI376/TY1ai4nKigNybdxXyFNAW mJsVvuBa+0Y+hZycN0qguYWQ2yr6Ux2E2hasuYZx1Gv6VlsIKwzkLKr6cJihhTjTbeyr Mwhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hNA3XTS5DPSVyhTn9bRvz8ndXP6Z0e0MigidvKOT658=; b=FpS3MTHCwDXdPLX3lGSL6CYKezWi/rnE5rv6gtOpx7SJhZNDXGX84P5LSOEGZuTf65 DQL7XLq6Hke9lKw7EUpbuugRD5wPCqjdDlcV47ar5LXs9uF1WKHpGRtxFKONjOzupqfa xoM1sglht91KlhCEp+AHhwYLCYP7/ep0ykVlEiI49EG4jrEnpmw4Xycnu8VMLwsnOuKT nx728A4j8oicjMaBcG7Zb2CE34/pJPZVy75Oe/JKdvMTOjFOjH3Th04bGhXdt6Cxm56c yPplmFTrWUZkO5n+iqybu5JGHbUWtT50/hmP6Y3mZT0ILCrMT4guNX/D8Jtwr6Zbhvnd D8Iw== X-Gm-Message-State: ANoB5plLcYXZ1BZWKN6wiCG2H5d4eAQXUKVwmWEr+nKvMw62HqPpmUlP OkqfCFXBmLwryxE8rh8efnL95wdP0zE= X-Google-Smtp-Source: AA0mqf4bbVRkGJmVHBv0Dgusbt9Nao9uWZiCBcNxHhJ2XG0O6xn9eSASgN9dIFRO0le/BD9OJcxoQQ== X-Received: by 2002:a5d:6e87:0:b0:242:5057:8b15 with SMTP id k7-20020a5d6e87000000b0024250578b15mr5668312wrz.66.1670700142081; Sat, 10 Dec 2022 11:22:22 -0800 (PST) Original-Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id p12-20020a056000018c00b002420a2cdc96sm4550579wrx.70.2022.12.10.11.22.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 10 Dec 2022 11:22:21 -0800 (PST) Content-Language: en-US In-Reply-To: <86a63vi2lu.fsf@mail.linkov.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250548 Archived-At: On 10/12/2022 19:45, Juri Linkov wrote: >> Not sure what's the best fix here (especially in time for the release), >> but if the FILTER-PREDICATE arg to list-buffers-noselect turned into a >> factory function (e.g. FILTER-PREDICATE-MAKER), that would be one >> solution. > > I see only one solution: to replace the argument FILTER-PREDICATE > with BUFFER-LIST-FUNCTION. Ah yeah, that should also work. >>> Curiously, though, it shows a different list of buffers. It also >>> includes "hidden" buffers - diff-syntax, Echo Area, etc. We should look >>> into that either way. >> + (cl-delete-if-not >> + (lambda (b) >> + (or (buffer-file-name b) >> + (string-match-p "\\`[^ ]" (buffer-name b)))) >> + (project-buffers pr))))) > > Please try to copy the exact logic from list-buffers--refresh: > > (and (or (not (string= (substring name 0 1) " ")) > buffer-file-name) > (not (eq buffer (current-buffer))) > (or file (not Buffer-menu-files-only)) Do you have the time to finish the fix yourself? It was your feature, after all.