From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#11810: 24.1.50; `vc-diff' shrinks pre-existing window Date: Fri, 06 Jul 2012 16:25:57 +0400 Message-ID: <4FF6D955.9010908@yandex.ru> References: <4FECAF0F.1080307@yandex.ru> <4FED556A.4060702@gmx.at> <4FEE2EA5.5060905@yandex.ru> <4FEEC259.7040308@gmx.at> <4FEF8935.9010508@yandex.ru> <4FF012FE.1010502@gmx.at> <4FF05DC0.4080609@yandex.ru> <4FF146F4.1080103@gmx.at> <4FF1A30F.4090806@yandex.ru> <4FF1CD2C.5000704@gmx.at> <4FF206F5.4030101@yandex.ru> <4FF29BE7.2030006@gmx.at> <4FF2EA0D.9030006@yandex.ru> <4FF3207B.1050609@gmx.at> <4FF3404E.6000207@yandex.ru> <4FF40A6C.2050601@gmx.at> <4FF46B89.5040301@yandex.ru> <4FF56410.7000705@gmx.at> <4FF62109.6000608@yandex.ru> <4FF6876E.2050904@gmx.at> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1341577641 4488 80.91.229.3 (6 Jul 2012 12:27:21 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 6 Jul 2012 12:27:21 +0000 (UTC) Cc: 11810@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 06 14:27:20 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Sn7d1-0007sZ-U3 for geb-bug-gnu-emacs@m.gmane.org; Fri, 06 Jul 2012 14:27:20 +0200 Original-Received: from localhost ([::1]:47041 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sn7d0-00011L-UJ for geb-bug-gnu-emacs@m.gmane.org; Fri, 06 Jul 2012 08:27:18 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:34181) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sn7ct-00010X-FB for bug-gnu-emacs@gnu.org; Fri, 06 Jul 2012 08:27:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sn7cn-0001H9-4F for bug-gnu-emacs@gnu.org; Fri, 06 Jul 2012 08:27:11 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:42064) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sn7cm-0001H4-Pt for bug-gnu-emacs@gnu.org; Fri, 06 Jul 2012 08:27:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1Sn7hZ-0003hO-Vh for bug-gnu-emacs@gnu.org; Fri, 06 Jul 2012 08:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 06 Jul 2012 12:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11810 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 11810-submit@debbugs.gnu.org id=B11810.134157788214170 (code B ref 11810); Fri, 06 Jul 2012 12:32:01 +0000 Original-Received: (at 11810) by debbugs.gnu.org; 6 Jul 2012 12:31:22 +0000 Original-Received: from localhost ([127.0.0.1]:51610 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sn7gv-0003gU-5k for submit@debbugs.gnu.org; Fri, 06 Jul 2012 08:31:22 -0400 Original-Received: from forward14.mail.yandex.net ([95.108.130.92]:56396) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sn7gr-0003gJ-2f for 11810@debbugs.gnu.org; Fri, 06 Jul 2012 08:31:19 -0400 Original-Received: from smtp11.mail.yandex.net (smtp11.mail.yandex.net [95.108.130.67]) by forward14.mail.yandex.net (Yandex) with ESMTP id 6A13D1982974; Fri, 6 Jul 2012 16:26:17 +0400 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1341577577; bh=LzCnXhgeMhynza3FNp9zrAbouGLlHn756AHaui4cBzo=; h=Message-ID:Date:From:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=O9qeMXAqQc9GfPCUYZ2ycpT4synvoVghTIOl8225nzIohHU4cVSkxYuc5VSmtF0WG vjAYHC0KLn4t3U5raZiHcgY3gzgx3CRlFPt8O1W4x3c2bevHnvLSLpqLRlfO5PgtSa Ky6jXHffFtFNh12kTXZNIpniLpfavACEtSRcdO5I= Original-Received: from smtp11.mail.yandex.net (localhost [127.0.0.1]) by smtp11.mail.yandex.net (Yandex) with ESMTP id 4848F7E00C3; Fri, 6 Jul 2012 16:26:17 +0400 (MSK) Original-Received: from 98-87.nwlink.spb.ru (98-87.nwlink.spb.ru [178.252.98.87]) by smtp11.mail.yandex.net (nwsmtp/Yandex) with ESMTP id QGVuVCFB-QGVudMdK; Fri, 6 Jul 2012 16:26:16 +0400 X-Yandex-Rcpt-Suid: rudalics@gmx.at X-Yandex-Rcpt-Suid: 11810@debbugs.gnu.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1341577577; bh=LzCnXhgeMhynza3FNp9zrAbouGLlHn756AHaui4cBzo=; h=Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject: References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=DzjpZtyNEPQgSpyJ5bM92Ywql8j5Em8n/b/dWS2L2Z6VsvbY4M7NfqJsSc7urg5NP yoY4ZgyP3aW8eKgea6wJ1rV+FhUcUAfnn4bYcwqZR/mM8wfQJ3IoHXKXvmxtN9wlxJ uYCeYT3WYPEqRIi2TNgRrtg7F4l+NC+sxVSilOt4= User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 In-Reply-To: <4FF6876E.2050904@gmx.at> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:61644 Archived-At: On 06.07.2012 10:36, martin rudalics wrote: > >> I'm more concerned with the fact that an application might reuse the > >> shrunk window via `display-buffer'. > > > > In this case, unless the new buffer is the same as the one already > > displayed in the shrunk window, `display-buffer-record-window' will > > overwrite the 'quit-restore parameter, so I don't see what the problem > > scenario would be. Hadn't managed to reproduce one either. > > Consider users with always <= 2 windows per frame: If `display-buffer' > displays some temporary buffer in the other, reused window, shrinking it > to some few lines, calling `switch-to-buffer-other-window' in that > situation won't be of much fun. But that's an old issue. We could either prohibit shrinking, which apparently isn't an option, or restore saved height before displaying the new buffer (in `display-buffer-use-some-window', for example). Would that be the expected behavior? > >> > If someone wants `shrink-window-if-...' to have no effect only in > >> > `vc-diff', well, that's a different goal. > >> > >> But that's probably what some people want. > > > > I don't think we've seen a request exactly like that yet, but that would > > require a vc-prefixed variable. > > When we get such a request you'll take care of it ;-) Maybe. :) You'd have to notify me if I miss the bug. > > window.el (quit-window): Always restore window height when it's saved in > > quit-restore parameter. > > Installed as revision 108897. Works as expected. I believe this can be tagged as fixed now. --Dmitry