From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#11810: 24.1.50; `vc-diff' shrinks pre-existing window Date: Thu, 05 Jul 2012 11:53:20 +0200 Message-ID: <4FF56410.7000705@gmx.at> References: <4FECAF0F.1080307@yandex.ru> <4FED556A.4060702@gmx.at> <4FEE2EA5.5060905@yandex.ru> <4FEEC259.7040308@gmx.at> <4FEF8935.9010508@yandex.ru> <4FF012FE.1010502@gmx.at> <4FF05DC0.4080609@yandex.ru> <4FF146F4.1080103@gmx.at> <4FF1A30F.4090806@yandex.ru> <4FF1CD2C.5000704@gmx.at> <4FF206F5.4030101@yandex.ru> <4FF29BE7.2030006@gmx.at> <4FF2EA0D.9030006@yandex.ru> <4FF3207B.1050609@gmx.at> <4FF3404E.6000207@yandex.ru> <4FF40A6C.2050601@gmx.at> <4FF46B89.5040301@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1341482065 29580 80.91.229.3 (5 Jul 2012 09:54:25 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 5 Jul 2012 09:54:25 +0000 (UTC) Cc: 11810@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jul 05 11:54:25 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SmilT-0002eH-Ar for geb-bug-gnu-emacs@m.gmane.org; Thu, 05 Jul 2012 11:54:23 +0200 Original-Received: from localhost ([::1]:34373 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SmilS-00039A-CK for geb-bug-gnu-emacs@m.gmane.org; Thu, 05 Jul 2012 05:54:22 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:35897) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SmilJ-0002la-9n for bug-gnu-emacs@gnu.org; Thu, 05 Jul 2012 05:54:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SmilH-0006Na-4m for bug-gnu-emacs@gnu.org; Thu, 05 Jul 2012 05:54:12 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:40169) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SmilH-0006NU-1w for bug-gnu-emacs@gnu.org; Thu, 05 Jul 2012 05:54:11 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1Smipy-00008N-3A for bug-gnu-emacs@gnu.org; Thu, 05 Jul 2012 05:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Jul 2012 09:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11810 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 11810-submit@debbugs.gnu.org id=B11810.1341482312474 (code B ref 11810); Thu, 05 Jul 2012 09:59:02 +0000 Original-Received: (at 11810) by debbugs.gnu.org; 5 Jul 2012 09:58:32 +0000 Original-Received: from localhost ([127.0.0.1]:49715 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SmipU-00007b-Cu for submit@debbugs.gnu.org; Thu, 05 Jul 2012 05:58:32 -0400 Original-Received: from mailout-de.gmx.net ([213.165.64.22]:53961) by debbugs.gnu.org with smtp (Exim 4.72) (envelope-from ) id 1SmipR-00007T-Pr for 11810@debbugs.gnu.org; Thu, 05 Jul 2012 05:58:30 -0400 Original-Received: (qmail invoked by alias); 05 Jul 2012 09:53:37 -0000 Original-Received: from 62-47-44-165.adsl.highway.telekom.at (EHLO [62.47.44.165]) [62.47.44.165] by mail.gmx.net (mp012) with SMTP; 05 Jul 2012 11:53:37 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX18pgTIoNC8pyazvxomys+eQeiPTMn6yqlsR7RUsuY CC2I8bV8687557 In-Reply-To: <4FF46B89.5040301@yandex.ru> X-Y-GMX-Trusted: 0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:61601 Archived-At: > I tried it with just my patch applied, and it didn't work, because in > this case the stored height value was of already resized window: > `display-buffer-record-window' is called from `window--display-buffer', > and `display-buffer-use-some-window' calls `window--even-window-heights' > before `window--display-buffer'. I think we could do (when window (prog1 (window--display-buffer buffer window 'reuse) (window--even-window-heights window))) in `display-buffer-use-some-window'. > Maybe that's fine, I'll just set the variable to nil. OK > Until then, the issue is somewhat alleviated by the fact that you can > press 'z' or 'C-x k' instead of 'q', and both of these won't trigger > height restoration. I'm more concerned with the fact that an application might reuse the shrunk window via `display-buffer'. > If someone wants `shrink-window-if-...' to have no effect only in > `vc-diff', well, that's a different goal. But that's probably what some people want. >> Let's close this thread as follows: Remove the `temp-buffer-resize-mode' >> check in `quit-window' and add an integerp check for the third element. > > Agreed. Can you install it? Else please post the patch and a ChangeLog entry. >> (1) have `vc-diff' use something similar to `with-output-to-temp-buffer' >> so that `temp-buffer-resize-mode' is honored, >> >> (2) resize the window only if `temp-buffer-resize-mode' is enabled, or > > Both 1 and 2 would be fine, I think, although 1 would require some extra > work to make it work asynchronously. IIUC, `with-output-to-temp-buffer' > waits until the called process completes, and `vc-diff' supports both > synchronous and asynchronous execution. We need a susbstitute for `with-output-to-temp-buffer' for asynchronously filled buffers. martin