From: Dmitry Gutov <dgutov@yandex.ru>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: 11757@debbugs.gnu.org
Subject: bug#11757: Acknowledgement (24.1.50; vc-git calls `process-file' too many times)
Date: Mon, 02 Jul 2012 16:44:22 +0400 [thread overview]
Message-ID: <4FF197A6.7060807@yandex.ru> (raw)
In-Reply-To: <878vf2sf7q.fsf@gmx.de>
On 02.07.2012 13:08, Michael Albinus wrote:
> Dmitry Gutov <dgutov@yandex.ru> writes:
>
>>> Likely, the best option is to call (vc-registered file) after clearing
>>> the file cache. This recomputes the 'vc-backend property as well, what
>>> we want.
>>
>> Have you tried this? (vc-backend file) gets called just a bit later,
>> in `vc-after-save`, and it calls `vc-registered' in turn, but since
>> the file is no longer registered with Git, it returns nil, and the
>> mode-line is not updated.
>
> Well, I've played with it. Scenario:
I believe both scenarios below would work just as well with my original
patch.
> - Have a git-controlled file on disk
> - Load it in Emacs.
> - Remove it on disk, outside Emacs.
> - Save it from Emacs
>
> In vc-before-save, the file cache is cleared 'cause the file doesn't
> exist any longer. As you said, vc-backend is called afterwards,
> recomputing some of the properties. The file shows the correct modeline,
> "Git:master".
If you just removed it on disk, without committing the change, doing
(vc-state-refresh) would correctly recompute its status as 'removed even
without calling (vc-registered).
That's not the status we have a problem with ('unregistered is).
> 2nd scenario:
>
> - Switch to another branch ("git checkout test")
> - Remove the file on disk, outside Emacs.
> - Save it from Emacs
>
> And now the modeline shows "Git:test", as expected.
Was the file absent in the branch test after checkout? If not, this case
is no different from the first.
Basically, we need a scenario in which `vc-next-action' will need to
call `vc-git-register' on a file that recently has been considered
'up-to-date.
>> So from this standpoint, saving and restoring 'vc-backend value around
>> clearing props in `vc-before-save' might indeed be the best solution.
>
> I believe, we even don't need this. The current code DTRT, and clearing
> the properties happens only when the file has been removed.
I believe we can either not call 'vc-git-registered' from `vc-git-state'
at all (caching 'git-registered is not needed in this case), or we
should fix some scenario which benefits from us doing that.
The logic is rather complicated there, so I might easily be missing some
examples. If so, please tell.
-- Dmitry
next prev parent reply other threads:[~2012-07-02 12:44 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-21 2:12 bug#11757: 24.1.50; vc-git calls `process-file' too many times Dmitry Gutov
[not found] ` <handler.11757.B.13402450035158.ack@debbugs.gnu.org>
2012-06-26 10:54 ` bug#11757: Acknowledgement (24.1.50; vc-git calls `process-file' too many times) Dmitry Gutov
2012-06-26 12:14 ` Michael Albinus
2012-06-28 0:51 ` Dmitry Gutov
2012-06-29 13:46 ` Michael Albinus
2012-06-29 16:06 ` Dmitry Gutov
2012-06-29 16:40 ` Michael Albinus
2012-06-29 17:03 ` Dmitry Gutov
2012-06-29 17:38 ` Michael Albinus
2012-06-30 9:03 ` Michael Albinus
2012-06-30 12:56 ` Dmitry Gutov
2012-06-30 13:19 ` Michael Albinus
2012-06-30 17:42 ` Dmitry Gutov
2012-06-30 18:46 ` Michael Albinus
2012-06-30 19:14 ` Dmitry Gutov
2012-07-01 9:58 ` Michael Albinus
2012-07-01 14:58 ` Dmitry Gutov
[not found] ` <4FF062D7.7050402@yandex.ru>
[not found] ` <878vf2sf7q.fsf@gmx.de>
2012-07-02 12:42 ` Dmitry Gutov
2012-07-02 12:44 ` Dmitry Gutov [this message]
2012-07-04 15:10 ` Michael Albinus
2012-07-04 16:42 ` Dmitry Gutov
2012-07-06 13:44 ` Michael Albinus
2012-07-06 15:55 ` Dmitry Gutov
[not found] ` <5000D21F.6080900@yandex.ru>
[not found] ` <87k3y36gbe.fsf@gmx.de>
[not found] ` <50046AD3.1080605@yandex.ru>
[not found] ` <87y5min9ad.fsf@gmx.de>
[not found] ` <50063692.7080707@yandex.ru>
2012-07-18 14:38 ` Michael Albinus
2012-07-18 17:01 ` Dmitry Gutov
2012-06-30 23:01 ` Stefan Monnier
2012-06-30 23:38 ` Dmitry Gutov
2012-07-18 14:11 ` bug#11757: Fwd: " Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF197A6.7060807@yandex.ru \
--to=dgutov@yandex.ru \
--cc=11757@debbugs.gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.