From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#11757: Acknowledgement (24.1.50; vc-git calls `process-file' too many times) Date: Sat, 30 Jun 2012 23:14:18 +0400 Message-ID: <4FEF500A.9060103@yandex.ru> References: <4FE2832A.1030308@yandex.ru> <4FE994E8.9020605@yandex.ru> <87zk7qs21q.fsf@gmx.de> <4FEBAAAA.3030102@yandex.ru> <87d34igrie.fsf@gmx.de> <4FEDD2A0.3010300@yandex.ru> <878vf66pgw.fsf@gmx.de> <4FEDDFD8.1010407@yandex.ru> <87wr2pgoiy.fsf@gmx.de> <4FEEF763.2060806@yandex.ru> <878vf5544d.fsf@gmx.de> <4FEF3A87.6000904@yandex.ru> <874nps63ki.fsf@gmx.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1341083691 14335 80.91.229.3 (30 Jun 2012 19:14:51 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 30 Jun 2012 19:14:51 +0000 (UTC) Cc: 11757@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jun 30 21:14:50 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Sl381-000852-IB for geb-bug-gnu-emacs@m.gmane.org; Sat, 30 Jun 2012 21:14:45 +0200 Original-Received: from localhost ([::1]:53599 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sl381-0002mf-G7 for geb-bug-gnu-emacs@m.gmane.org; Sat, 30 Jun 2012 15:14:45 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:47624) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sl37w-0002lW-9k for bug-gnu-emacs@gnu.org; Sat, 30 Jun 2012 15:14:43 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sl37u-0006a7-JQ for bug-gnu-emacs@gnu.org; Sat, 30 Jun 2012 15:14:39 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:58196) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sl37u-0006a3-9B for bug-gnu-emacs@gnu.org; Sat, 30 Jun 2012 15:14:38 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1Sl3CA-0000Tm-9I for bug-gnu-emacs@gnu.org; Sat, 30 Jun 2012 15:19:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 30 Jun 2012 19:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11757 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 11757-submit@debbugs.gnu.org id=B11757.13410839261819 (code B ref 11757); Sat, 30 Jun 2012 19:19:02 +0000 Original-Received: (at 11757) by debbugs.gnu.org; 30 Jun 2012 19:18:46 +0000 Original-Received: from localhost ([127.0.0.1]:39509 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sl3Bu-0000TH-1w for submit@debbugs.gnu.org; Sat, 30 Jun 2012 15:18:46 -0400 Original-Received: from forward11.mail.yandex.net ([95.108.130.93]:60091) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sl3Bq-0000T7-08 for 11757@debbugs.gnu.org; Sat, 30 Jun 2012 15:18:44 -0400 Original-Received: from smtp11.mail.yandex.net (smtp11.mail.yandex.net [95.108.130.67]) by forward11.mail.yandex.net (Yandex) with ESMTP id 9E6CEE81CEA; Sat, 30 Jun 2012 23:14:15 +0400 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1341083655; bh=QsreYHJL53Vkt9n9O0RNJ/ZLdWQcypz27RT063AHgrk=; h=Message-ID:Date:From:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=RO1gW+INAovZUJIwIKRlz3zZn3Ig/DAdxDMw8D1++mzZfP7tIgjaB3oqJvXkQNy/N Z/VRJuuqEGgkgcQ16gXqtyFKReZpQ8uElbbM7tQZgp4eX4+2iBh/GAikjHKWwG7uTn QFH3nZK520cW0lDnmXAilXqwTN90aqt/hF85psYs= Original-Received: from smtp11.mail.yandex.net (localhost [127.0.0.1]) by smtp11.mail.yandex.net (Yandex) with ESMTP id 7E94D7E0482; Sat, 30 Jun 2012 23:14:15 +0400 (MSK) Original-Received: from 98-87.nwlink.spb.ru (98-87.nwlink.spb.ru [178.252.98.87]) by smtp11.mail.yandex.net (nwsmtp/Yandex) with ESMTP id EFViqU4s-EFVufoRC; Sat, 30 Jun 2012 23:14:15 +0400 X-Yandex-Rcpt-Suid: michael.albinus@gmx.de X-Yandex-Rcpt-Suid: 11757@debbugs.gnu.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1341083655; bh=QsreYHJL53Vkt9n9O0RNJ/ZLdWQcypz27RT063AHgrk=; h=Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject: References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=F5HcT9RMsafZ3+kQTmgPr6guwj75zKiYt2enjW3OcSna5JWQ6ELgLbQZXflKPjJfz FModSXRydrOkQmqRO1IQh6uMOET7+m+VMxAmcN6XALwq0+7k4X2R9l8RrhaB7lQrOO oZLf+deGeiwvkf9CpqCNUOkedi6A7yD6rAEmvWRI= User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 In-Reply-To: <874nps63ki.fsf@gmx.de> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:61445 Archived-At: On 30.06.2012 22:46, Michael Albinus wrote: > Dmitry Gutov writes: > >> This way, `vc-before-save' clears 'vc-backend property too and >> (vc-backend file) retuns nil in `vc-after-save', and the mode-line >> isn't getting updated. > > So we might let-bind the 'vc-backend property to a local variable, and > reset it after cleanup. It would work, but this, yet again, complicates the logic. >> I'm not sure what we should do. Call (vc-mode-line) anyway? That would work. > > Nope. This is expansive, because it recomputes `vc-working-revision'. We > would loose all improvements from using the cache. I don't think so. If we hadn't reset all properties in vc-before-save (file existed), nothing changes. If we did reset them, then yes, vc-working-revision will recompute 'vc-working-revision property, but only once after the reset. Which is what we want to do anyway, since the file's state has changed, and the working revision could have changed as well, so we need to know them to update mode-line. By the way, this last patch I sent doesn't help if the user just removed the file from repository while leaving it on disk (git rm --cached ... && git commit ..., for example), but whatever.