From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#11757: Acknowledgement (24.1.50; vc-git calls `process-file' too many times) Date: Sat, 30 Jun 2012 21:42:31 +0400 Message-ID: <4FEF3A87.6000904@yandex.ru> References: <4FE2832A.1030308@yandex.ru> <4FE994E8.9020605@yandex.ru> <87zk7qs21q.fsf@gmx.de> <4FEBAAAA.3030102@yandex.ru> <87d34igrie.fsf@gmx.de> <4FEDD2A0.3010300@yandex.ru> <878vf66pgw.fsf@gmx.de> <4FEDDFD8.1010407@yandex.ru> <87wr2pgoiy.fsf@gmx.de> <4FEEF763.2060806@yandex.ru> <878vf5544d.fsf@gmx.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1341078230 10414 80.91.229.3 (30 Jun 2012 17:43:50 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 30 Jun 2012 17:43:50 +0000 (UTC) Cc: 11757@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jun 30 19:43:49 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Sl1hw-00070r-4d for geb-bug-gnu-emacs@m.gmane.org; Sat, 30 Jun 2012 19:43:44 +0200 Original-Received: from localhost ([::1]:47085 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sl1hv-0003vI-Qi for geb-bug-gnu-emacs@m.gmane.org; Sat, 30 Jun 2012 13:43:43 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:33464) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sl1ht-0003vD-Ai for bug-gnu-emacs@gnu.org; Sat, 30 Jun 2012 13:43:42 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sl1hr-0003U6-Eg for bug-gnu-emacs@gnu.org; Sat, 30 Jun 2012 13:43:40 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:58127) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sl1hr-0003U1-3w for bug-gnu-emacs@gnu.org; Sat, 30 Jun 2012 13:43:39 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1Sl1m6-00028M-Ey for bug-gnu-emacs@gnu.org; Sat, 30 Jun 2012 13:48:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 30 Jun 2012 17:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11757 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 11757-submit@debbugs.gnu.org id=B11757.13410784467930 (code B ref 11757); Sat, 30 Jun 2012 17:48:02 +0000 Original-Received: (at 11757) by debbugs.gnu.org; 30 Jun 2012 17:47:26 +0000 Original-Received: from localhost ([127.0.0.1]:39440 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sl1lV-00023n-6p for submit@debbugs.gnu.org; Sat, 30 Jun 2012 13:47:25 -0400 Original-Received: from forward11.mail.yandex.net ([95.108.130.93]:37274) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sl1lQ-00023R-7W for 11757@debbugs.gnu.org; Sat, 30 Jun 2012 13:47:23 -0400 Original-Received: from smtp13.mail.yandex.net (smtp13.mail.yandex.net [95.108.130.68]) by forward11.mail.yandex.net (Yandex) with ESMTP id 3B3EDE81BF4; Sat, 30 Jun 2012 21:42:54 +0400 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1341078174; bh=d+0JolkBIA5c7UizsXGdq87Nc7qXFK/e3UJqhPhK2h8=; h=Message-ID:Date:From:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=e79SkZ+boS9+TZt9DhuOIxxL673PoFBhgn5CZ/tD/ZU/VofBlsMgGSQy65GV9K8FN t4XAHTxFK8SBQwdoyrdK7Uo17b4Z5+K/bYL5VaXSXEYjMIPDyh70TeW8l/kBzYV0N8 h30OsIsYEbMtQTVb7E78pP0DrQF+X11SUTHvuVqc= Original-Received: from smtp13.mail.yandex.net (localhost [127.0.0.1]) by smtp13.mail.yandex.net (Yandex) with ESMTP id 17E14E40482; Sat, 30 Jun 2012 21:42:54 +0400 (MSK) Original-Received: from 98-87.nwlink.spb.ru (98-87.nwlink.spb.ru [178.252.98.87]) by smtp13.mail.yandex.net (nwsmtp/Yandex) with ESMTP id go9WtICY-go9iCEST; Sat, 30 Jun 2012 21:42:50 +0400 X-Yandex-Rcpt-Suid: michael.albinus@gmx.de X-Yandex-Rcpt-Suid: 11757@debbugs.gnu.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1341078174; bh=d+0JolkBIA5c7UizsXGdq87Nc7qXFK/e3UJqhPhK2h8=; h=Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject: References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=ZiZ535MvA8zmbY2NcsGsn5uexWY+NhNqBlu26ikQTEIHBBdRNvNT8XoHXzfPU9/92 w617aFFpMxJT2IVExHwodHycd70uEFO9QXeG+LkL1QVUBPT837Pj7JKNtIynMycS84 4VpZtGyLOER/bZFMRNIT5YwugKzmFzOwqUlQWoJQ= User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 In-Reply-To: <878vf5544d.fsf@gmx.de> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:61442 Archived-At: On 30.06.2012 17:19, Michael Albinus wrote: > Dmitry Gutov writes: > >> Here's what I had in mind: > > Well, I've committed both your and my patch. Can we close the ticket now? Uh, probably not. This was not enough to fully fix the scenario of writing to a file that was removed from Git externally. This way, `vc-before-save' clears 'vc-backend property too and (vc-backend file) retuns nil in `vc-after-save', and the mode-line isn't getting updated. I'm not sure what we should do. Call (vc-mode-line) anyway? That would work. Clearing only some properties in `vc-before-save' wouldn't be very sane, since 'git-registered is backend-specific. There's a major inconsistency in `vc-backend' logic: we have a way to display mode-line, refresh state, etc, for a file that's been registered in VC but then was removed, as long as the buffer wasn't killed, but kill it and open the file again - now (vc-backend) returns nil. -- Dmitry