From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: inline build_string performance Date: Tue, 26 Jun 2012 10:37:34 -0700 Organization: UCLA Computer Science Department Message-ID: <4FE9F35E.1060309@cs.ucla.edu> References: <4FE9CCFF.2060309@cs.ucla.edu> <4FE9E374.8010007@yandex.ru> <4FE9E691.9090906@cs.ucla.edu> <4FE9F26E.6010700@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1340732268 2513 80.91.229.3 (26 Jun 2012 17:37:48 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 26 Jun 2012 17:37:48 +0000 (UTC) Cc: Emacs Development To: Dmitry Antipov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jun 26 19:37:47 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SjZhx-00076N-Fp for ged-emacs-devel@m.gmane.org; Tue, 26 Jun 2012 19:37:45 +0200 Original-Received: from localhost ([::1]:59178 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SjZhx-0001X7-86 for ged-emacs-devel@m.gmane.org; Tue, 26 Jun 2012 13:37:45 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:41242) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SjZhr-0001Wm-0A for Emacs-devel@gnu.org; Tue, 26 Jun 2012 13:37:43 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SjZhp-0000cW-Cp for Emacs-devel@gnu.org; Tue, 26 Jun 2012 13:37:38 -0400 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:54674) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SjZhp-0000cC-6i for Emacs-devel@gnu.org; Tue, 26 Jun 2012 13:37:37 -0400 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 1AE6FA60005; Tue, 26 Jun 2012 10:37:35 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0iVAiv9PgnqK; Tue, 26 Jun 2012 10:37:34 -0700 (PDT) Original-Received: from penguin.cs.ucla.edu (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 9C20839E800B; Tue, 26 Jun 2012 10:37:34 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 In-Reply-To: <4FE9F26E.6010700@yandex.ru> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 131.179.128.62 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:151194 Archived-At: On 06/26/2012 10:33 AM, Dmitry Antipov wrote: > This may be implemented without reverting previous stuff. Sure, but if we we use build_literal for literals, and build_string for non-literals, there's a performance downside for having build_string be inline (namely, it bloats the code), but no performance upside. Perhaps I'm not quite following your idea, as I thought the signature would be build_literal ("foo"), whereas your build_literal also wants the string length.