* bug#18474: trunk; Warning in callproc.c while building for Mac OS X on trunk
@ 2014-09-14 5:55 David Caldwell
2014-09-14 8:24 ` Jan Djärv
0 siblings, 1 reply; 2+ messages in thread
From: David Caldwell @ 2014-09-14 5:55 UTC (permalink / raw)
To: 18474
[-- Attachment #1: Type: text/plain, Size: 862 bytes --]
While building on Mac OS X, this code in src/callproc.c (line 1582ish):
#ifdef HAVE_NS
if (data_dir == 0)
data_dir == ns_etc_directory () != 0;
#endif
gives a warning:
cc -c -Demacs -I. -I. -I../lib -I../lib -MMD -MF
deps/callproc.d -MP -Wno-switch
-Wno-tautological-constant-out-of-range-compare -Wno-pointer-sign -g3
-O2 callproc.c
callproc.c:1582:14: warning: comparison between pointer and integer
('int' and 'const char *')
data_dir == ns_etc_directory () != 0;
~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~
callproc.c:1582:37: warning: inequality comparison result unused
[-Wunused-comparison]
data_dir == ns_etc_directory () != 0;
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
2 warnings generated.
Maybe s/==/=/ ?
Looks like it was added in bzr r117829 (the huge alloca() patch).
-David
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4219 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread* bug#18474: trunk; Warning in callproc.c while building for Mac OS X on trunk
2014-09-14 5:55 bug#18474: trunk; Warning in callproc.c while building for Mac OS X on trunk David Caldwell
@ 2014-09-14 8:24 ` Jan Djärv
0 siblings, 0 replies; 2+ messages in thread
From: Jan Djärv @ 2014-09-14 8:24 UTC (permalink / raw)
To: David Caldwell; +Cc: 18474-done
Hello.
14 sep 2014 kl. 07:55 skrev David Caldwell <david@porkrind.org>:
>
> While building on Mac OS X, this code in src/callproc.c (line 1582ish):
>
> #ifdef HAVE_NS
> if (data_dir == 0)
> data_dir == ns_etc_directory () != 0;
> #endif
>
> gives a warning:
>
> cc -c -Demacs -I. -I. -I../lib -I../lib -MMD -MF
> deps/callproc.d -MP -Wno-switch
> -Wno-tautological-constant-out-of-range-compare -Wno-pointer-sign -g3
> -O2 callproc.c
>
> callproc.c:1582:14: warning: comparison between pointer and integer
> ('int' and 'const char *')
> data_dir == ns_etc_directory () != 0;
> ~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~
> callproc.c:1582:37: warning: inequality comparison result unused
> [-Wunused-comparison]
> data_dir == ns_etc_directory () != 0;
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
>
> 2 warnings generated.
>
> Maybe s/==/=/ ?
>
> Looks like it was added in bzr r117829 (the huge alloca() patch).
An obvious typo, fixed now. Thanks.
Jan D.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-09-14 8:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-14 5:55 bug#18474: trunk; Warning in callproc.c while building for Mac OS X on trunk David Caldwell
2014-09-14 8:24 ` Jan Djärv
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.