From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jan =?UTF-8?Q?Dj=C3=A4rv?= Newsgroups: gmane.emacs.bugs Subject: bug#18474: trunk; Warning in callproc.c while building for Mac OS X on trunk Date: Sun, 14 Sep 2014 10:24:43 +0200 Message-ID: <4FE6A48B-E189-4048-A4CB-C1910B3C389C@swipnet.se> References: <54152DBD.6060400@porkrind.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1410683127 12834 80.91.229.3 (14 Sep 2014 08:25:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 14 Sep 2014 08:25:27 +0000 (UTC) Cc: 18474-done@debbugs.gnu.org To: David Caldwell Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 14 10:25:19 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XT57X-00021y-Az for geb-bug-gnu-emacs@m.gmane.org; Sun, 14 Sep 2014 10:25:19 +0200 Original-Received: from localhost ([::1]:53342 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XT57W-0004WR-UL for geb-bug-gnu-emacs@m.gmane.org; Sun, 14 Sep 2014 04:25:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52098) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XT57O-0004W9-Kr for bug-gnu-emacs@gnu.org; Sun, 14 Sep 2014 04:25:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XT57H-0001d4-15 for bug-gnu-emacs@gnu.org; Sun, 14 Sep 2014 04:25:10 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:49027) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XT57G-0001cr-Ux for bug-gnu-emacs@gnu.org; Sun, 14 Sep 2014 04:25:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XT57G-0007gx-KM for bug-gnu-emacs@gnu.org; Sun, 14 Sep 2014 04:25:02 -0400 Resent-From: Jan =?UTF-8?Q?Dj=C3=A4rv?= Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sun, 14 Sep 2014 08:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 18474 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 18474@debbugs.gnu.org, jan.h.d@swipnet.se, david@porkrind.org Original-Received: via spool by 18474-done@debbugs.gnu.org id=D18474.141068309029540 (code D ref 18474); Sun, 14 Sep 2014 08:25:01 +0000 Original-Received: (at 18474-done) by debbugs.gnu.org; 14 Sep 2014 08:24:50 +0000 Original-Received: from localhost ([127.0.0.1]:40589 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XT573-0007gN-76 for submit@debbugs.gnu.org; Sun, 14 Sep 2014 04:24:49 -0400 Original-Received: from mailfe03.swip.net ([212.247.154.65]:47964 helo=swip.net) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XT570-0007gD-D5 for 18474-done@debbugs.gnu.org; Sun, 14 Sep 2014 04:24:47 -0400 X-T2-Spam-Status: No, hits=0.0 required=5.0 Original-Received: from hosdjarv.se (account mj138573@tele2.se [46.59.42.57] verified) by mailfe03.swip.net (CommuniGate Pro SMTP 5.4.4) with ESMTPA id 364843367; Sun, 14 Sep 2014 10:24:44 +0200 In-Reply-To: <54152DBD.6060400@porkrind.org> X-Mailer: Apple Mail (2.1878.6) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:93356 Archived-At: Hello. 14 sep 2014 kl. 07:55 skrev David Caldwell : > > While building on Mac OS X, this code in src/callproc.c (line 1582ish): > > #ifdef HAVE_NS > if (data_dir == 0) > data_dir == ns_etc_directory () != 0; > #endif > > gives a warning: > > cc -c -Demacs -I. -I. -I../lib -I../lib -MMD -MF > deps/callproc.d -MP -Wno-switch > -Wno-tautological-constant-out-of-range-compare -Wno-pointer-sign -g3 > -O2 callproc.c > > callproc.c:1582:14: warning: comparison between pointer and integer > ('int' and 'const char *') > data_dir == ns_etc_directory () != 0; > ~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~ > callproc.c:1582:37: warning: inequality comparison result unused > [-Wunused-comparison] > data_dir == ns_etc_directory () != 0; > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~ > > 2 warnings generated. > > Maybe s/==/=/ ? > > Looks like it was added in bzr r117829 (the huge alloca() patch). An obvious typo, fixed now. Thanks. Jan D.